Bug 188555 - [LFC][Floating] Add support for negative clearance.
Summary: [LFC][Floating] Add support for negative clearance.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: zalan
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2018-08-14 08:55 PDT by zalan
Modified: 2018-08-14 20:00 PDT (History)
4 users (show)

See Also:

Attachments
Patch (17.65 KB, patch)
2018-08-14 09:05 PDT, zalan 		simon.fraser: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description zalan 2018-08-14 08:55:16 PDT 
ssia
Comment 1 zalan 2018-08-14 09:05:24 PDT 
Created attachment 347079 [details]
Patch
Comment 2 Simon Fraser (smfr) 2018-08-14 12:25:01 PDT 
Comment on attachment 347079 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=347079&action=review

> Source/WebCore/layout/FloatingContext.cpp:155
> +        auto absoluteTop = FormattingContext::mapTopLeftToAncestor(layoutContext, layoutBox, downcast<Container>(m_floatingState.root())).y;

Maybe don't call this absolute.

> Source/WebCore/layout/FloatingContext.cpp:164
> +            // Previous inlflow's bottom margin is collapsed.

inlflow's

Maybe explain the assertion better, like "Previous inflow sibling has been laid out already, so it's bottom margin will have been collapsed".

> Source/WebCore/layout/FloatingContext.cpp:168
> +            // Reset previous's bottom and current's top to non-collapsing.

Say previous box
Comment 3 zalan 2018-08-14 19:59:57 PDT 
Committed r234878: <https://trac.webkit.org/changeset/234878>
Comment 4 Radar WebKit Bug Importer 2018-08-14 20:00:24 PDT 
<rdar://problem/43316235>