RESOLVED FIXED 188555
[LFC][Floating] Add support for negative clearance. 
https://bugs.webkit.org/show_bug.cgi?id=188555
Summary [LFC][Floating] Add support for negative clearance.
zalan
Reported 2018-08-14 08:55:16 PDT
ssia
Attachments
Patch (17.65 KB, patch)
2018-08-14 09:05 PDT, zalan 		simon.fraser: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
zalan
Comment 1 2018-08-14 09:05:24 PDT
Created attachment 347079 [details] Patch
Simon Fraser (smfr)
Comment 2 2018-08-14 12:25:01 PDT
Comment on attachment 347079 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=347079&action=review > Source/WebCore/layout/FloatingContext.cpp:155 > + auto absoluteTop = FormattingContext::mapTopLeftToAncestor(layoutContext, layoutBox, downcast<Container>(m_floatingState.root())).y; Maybe don't call this absolute. > Source/WebCore/layout/FloatingContext.cpp:164 > + // Previous inlflow's bottom margin is collapsed. inlflow's Maybe explain the assertion better, like "Previous inflow sibling has been laid out already, so it's bottom margin will have been collapsed". > Source/WebCore/layout/FloatingContext.cpp:168 > + // Reset previous's bottom and current's top to non-collapsing. Say previous box
zalan
Comment 3 2018-08-14 19:59:57 PDT
Committed r234878: <https://trac.webkit.org/changeset/234878>
Radar WebKit Bug Importer
Comment 4 2018-08-14 20:00:24 PDT
<rdar://problem/43316235>
Note You need to log in before you can comment on or make changes to this bug.