Bug 188552 - [GStreamer][GL] useless ifdef in pushTextureToCompositor
Summary: [GStreamer][GL] useless ifdef in pushTextureToCompositor
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Platform (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Philippe Normand
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2018-08-14 06:11 PDT by Philippe Normand
Modified: 2018-08-31 03:25 PDT (History)
3 users (show)

See Also:

Attachments
Patch (3.72 KB, patch)
2018-08-14 06:15 PDT, Philippe Normand 		calvaris: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Philippe Normand 2018-08-14 06:11:17 PDT 
.
Comment 1 Philippe Normand 2018-08-14 06:15:10 PDT 
Created attachment 347070 [details]
Patch
Comment 2 Xabier Rodríguez Calvar 2018-08-14 22:46:55 PDT 
Comment on attachment 347070 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=347070&action=review

I think it is ok. Anyway, I'd wait until somebody like Miguel has a look at it as well.

> Source/WebCore/ChangeLog:10
> +        There's no need for a ifdef because the frame holder already

Nit: I think it is aN ifdef

> Source/WebCore/ChangeLog:11
> +        ensures a valid texture ID will set if it maps a GL video frame.

will BE set?
Comment 3 Miguel Gomez 2018-08-30 00:56:00 PDT 
Looks good to me.
Comment 4 Philippe Normand 2018-08-31 03:23:18 PDT 
Committed r235543: <https://trac.webkit.org/changeset/235543>
Comment 5 Radar WebKit Bug Importer 2018-08-31 03:25:25 PDT 
<rdar://problem/43933497>