Bug 188551 – Unhandled Promise Rejection logging in workers should not emit ErrorEvent to host Worker object

• Status: RESOLVED
• Resolution: FIXED
• Component: WebCore Misc.

[Yusuke Suzuki]

...

[Yusuke Suzuki]

Created attachment 347071 [details]
Patch

[EWS Watchlist]

Comment on attachment 347071 [details]
Patch

Attachment 347071 [details] did not pass mac-ews (mac):
Output: https://webkit-queues.webkit.org/results/8854950

New failing tests:
imported/w3c/web-platform-tests/streams/readable-streams/tee.dedicatedworker.html
http/wpt/workers/promise-unhandled-rejection.any.worker.html
js/dom/unhandled-promise-rejection-bindings-type-error-in-workers.html
imported/w3c/web-platform-tests/WebCryptoAPI/derive_bits_keys/ecdh_bits.https.worker.html
imported/w3c/web-platform-tests/WebCryptoAPI/derive_bits_keys/ecdh_keys.https.worker.html

[EWS Watchlist]

Created attachment 347073 [details]
Archive of layout-test-results from ews101 for mac-sierra

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews101  Port: mac-sierra  Platform: Mac OS X 10.12.6

[EWS Watchlist]

Comment on attachment 347071 [details]
Patch

Attachment 347071 [details] did not pass mac-wk2-ews (mac-wk2):
Output: https://webkit-queues.webkit.org/results/8854959

New failing tests:
imported/w3c/web-platform-tests/streams/readable-streams/tee.dedicatedworker.html
http/wpt/workers/promise-unhandled-rejection.any.worker.html
js/dom/unhandled-promise-rejection-bindings-type-error-in-workers.html
imported/w3c/web-platform-tests/WebCryptoAPI/derive_bits_keys/ecdh_bits.https.worker.html
imported/w3c/web-platform-tests/WebCryptoAPI/derive_bits_keys/ecdh_keys.https.worker.html

[EWS Watchlist]

Created attachment 347074 [details]
Archive of layout-test-results from ews105 for mac-sierra-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews105  Port: mac-sierra-wk2  Platform: Mac OS X 10.12.6

[Yusuke Suzuki]

Created attachment 347075 [details]
Patch

[Yusuke Suzuki]

Created attachment 347076 [details]
Patch

[youenn fablet]

Comment on attachment 347076 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=347076&action=review

> Source/WebCore/dom/ScriptExecutionContext.cpp:-411
> -    logExceptionToConsole(errorMessage, sourceURL, lineNumber, columnNumber, WTFMove(callStack));

Given its name, it seems strange that logExceptionToConsole would actually dispatch an Error event to the worker host.
Is there a way to make things clearer?

[Yusuke Suzuki]

Comment on attachment 347076 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=347076&action=review

>> Source/WebCore/dom/ScriptExecutionContext.cpp:-411
>> -    logExceptionToConsole(errorMessage, sourceURL, lineNumber, columnNumber, WTFMove(callStack));
> 
> Given its name, it seems strange that logExceptionToConsole would actually dispatch an Error event to the worker host.
> Is there a way to make things clearer?

The interesting is that this `logExceptionToConsole` just logs a message in Document while Worker emits ErrorEvent to the host Worker object.
Yeah, we should have appropriate name. Maybe, notifyException / propagateException / handleException etc.?
I've opened a bug for this. https://bugs.webkit.org/show_bug.cgi?id=188562

[Yusuke Suzuki]

Committed r234857: <https://trac.webkit.org/changeset/234857>

[Radar WebKit Bug Importer]

<rdar://problem/43293557>