RESOLVED FIXED 188541
[LFC][Floating] Do not confuse clear with clearance. 
https://bugs.webkit.org/show_bug.cgi?id=188541
Summary [LFC][Floating] Do not confuse clear with clearance.
zalan
Reported 2018-08-13 18:24:28 PDT
clear -> clear property clearance -> the offset required to avoid floats when clear is present.
Attachments
Patch (5.93 KB, patch)
2018-08-13 18:28 PDT, zalan 		simon.fraser: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
zalan
Comment 1 2018-08-13 18:28:51 PDT
Created attachment 347060 [details] Patch
Simon Fraser (smfr)
Comment 2 2018-08-13 18:37:37 PDT
Comment on attachment 347060 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=347060&action=review > Source/WebCore/layout/blockformatting/BlockFormattingContext.h:60 > + void computeVerticalPositionForClear(const FloatingContext&, const Box&, Display::Box&) const; I would like to see the word "float" somewhere in the function name. > Source/WebCore/layout/layouttree/LayoutBox.h:65 > + bool hasClear() const; This name sounds a bit too generic. Maybe hasFloatClear, or clearsFloats?
zalan
Comment 3 2018-08-13 18:47:43 PDT
Committed r234834: <https://trac.webkit.org/changeset/234834>
Radar WebKit Bug Importer
Comment 4 2018-08-13 18:48:18 PDT
<rdar://problem/43264418>
Note You need to log in before you can comment on or make changes to this bug.