Bug 188530 – [MotionMark] Update Leaves test

• Status: RESOLVED
• Resolution: FIXED
• Component: Animations

[Jon Lee]

Update Leaves test

[Radar WebKit Bug Importer]

<rdar://problem/43251862>

[Jon Lee]

Created attachment 347036 [details]
Patch

[Jon Lee]

Created attachment 347037 [details]
Patch

[Said Abou-Hallawa]

Comment on attachment 347037 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=347037&action=review

> PerformanceTests/MotionMark/tests/master/resources/leaves.js:85
> +        this.element.style.opacity = this._opacity;

The use of this._opacity is be guarded by this.usesOpacity unless this._opacity is always initialized with the default value. But I do not see that.

[Jon Lee]

Comment on attachment 347037 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=347037&action=review

>> PerformanceTests/MotionMark/tests/master/resources/leaves.js:85
>> +        this.element.style.opacity = this._opacity;
> 
> The use of this._opacity is be guarded by this.usesOpacity unless this._opacity is always initialized with the default value. But I do not see that.

Good point. It turns out that all of the subclasses do override the method. I'll fix this in the next version.

[WebKit Commit Bot]

Comment on attachment 347037 [details]
Patch

Clearing flags on attachment: 347037

Committed r234823: <https://trac.webkit.org/changeset/234823>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.