Bug 188530 - [MotionMark] Update Leaves test
Summary: [MotionMark] Update Leaves test
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Animations (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Jon Lee
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2018-08-13 14:20 PDT by Jon Lee
Modified: 2018-08-13 16:02 PDT (History)
8 users (show)

See Also:

Attachments
Patch (10.41 KB, patch)
2018-08-13 14:26 PDT, Jon Lee 		no flags Details | Formatted Diff | Diff
Patch (10.68 KB, patch)
2018-08-13 14:29 PDT, Jon Lee 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jon Lee 2018-08-13 14:20:44 PDT 
Update Leaves test
Comment 1 Radar WebKit Bug Importer 2018-08-13 14:21:23 PDT 
<rdar://problem/43251862>
Comment 2 Jon Lee 2018-08-13 14:26:56 PDT 
Created attachment 347036 [details]
Patch
Comment 3 Jon Lee 2018-08-13 14:29:41 PDT 
Created attachment 347037 [details]
Patch
Comment 4 Said Abou-Hallawa 2018-08-13 15:50:44 PDT 
Comment on attachment 347037 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=347037&action=review

> PerformanceTests/MotionMark/tests/master/resources/leaves.js:85
> +        this.element.style.opacity = this._opacity;

The use of this._opacity is be guarded by this.usesOpacity unless this._opacity is always initialized with the default value. But I do not see that.
Comment 5 Jon Lee 2018-08-13 15:56:55 PDT 
Comment on attachment 347037 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=347037&action=review

>> PerformanceTests/MotionMark/tests/master/resources/leaves.js:85
>> +        this.element.style.opacity = this._opacity;
> 
> The use of this._opacity is be guarded by this.usesOpacity unless this._opacity is always initialized with the default value. But I do not see that.

Good point. It turns out that all of the subclasses do override the method. I'll fix this in the next version.
Comment 6 WebKit Commit Bot 2018-08-13 16:02:14 PDT 
Comment on attachment 347037 [details]
Patch

Clearing flags on attachment: 347037

Committed r234823: <https://trac.webkit.org/changeset/234823>
Comment 7 WebKit Commit Bot 2018-08-13 16:02:16 PDT 
All reviewed patches have been landed.  Closing bug.