Bug 188525 - Added Thomas Denney to contributors.json.
Summary: Added Thomas Denney to contributors.json.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Thomas Denney
URL:
Keywords: InRadar
Depends on: 188536
Blocks:
  Show dependency tree / graph
 
Reported: 2018-08-13 12:07 PDT by Thomas Denney
Modified: 2018-08-20 12:22 PDT (History)
5 users (show)

See Also:

Attachments
Patch (1.36 KB, patch)
2018-08-13 12:07 PDT, Thomas Denney 		no flags Details | Formatted Diff | Diff
Patch (1.33 KB, patch)
2018-08-13 14:38 PDT, Thomas Denney 		no flags Details | Formatted Diff | Diff
Patch (1.31 KB, patch)
2018-08-13 16:57 PDT, Thomas Denney 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Thomas Denney 2018-08-13 12:07:13 PDT 
Added Thomas Denney to contributors.json.
Comment 1 Thomas Denney 2018-08-13 12:07:35 PDT 
Created attachment 347024 [details]
Patch
Comment 2 EWS Watchlist 2018-08-13 12:10:06 PDT 
Attachment 347024 [details] did not pass style-queue:


ERROR: Tools/Scripts/webkitpy/common/config/contributors.json:0:  contributors.json should not be modified through the commit queue  [json/syntax] [5]
Total errors found: 1 in 2 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 WebKit Commit Bot 2018-08-13 12:52:20 PDT 
Comment on attachment 347024 [details]
Patch

Clearing flags on attachment: 347024

Committed r234812: <https://trac.webkit.org/changeset/234812>
Comment 4 WebKit Commit Bot 2018-08-13 12:52:21 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 5 Radar WebKit Bug Importer 2018-08-13 12:53:22 PDT 
<rdar://problem/43247745>
Comment 6 Thomas Denney 2018-08-13 14:37:19 PDT 
Need to remove the line with contributor on.
Comment 7 Thomas Denney 2018-08-13 14:38:49 PDT 
Created attachment 347040 [details]
Patch
Comment 8 EWS Watchlist 2018-08-13 14:41:25 PDT 
Attachment 347040 [details] did not pass style-queue:


ERROR: Tools/Scripts/webkitpy/common/config/contributors.json:0:  contributors.json should not be modified through the commit queue  [json/syntax] [5]
Total errors found: 1 in 2 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 9 Thomas Denney 2018-08-13 16:57:47 PDT 
Created attachment 347055 [details]
Patch
Comment 10 EWS Watchlist 2018-08-13 16:59:51 PDT 
Attachment 347055 [details] did not pass style-queue:


ERROR: Tools/Scripts/webkitpy/common/config/contributors.json:0:  contributors.json should not be modified through the commit queue  [json/syntax] [5]
Total errors found: 1 in 2 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 11 WebKit Commit Bot 2018-08-20 12:22:32 PDT 
Comment on attachment 347055 [details]
Patch

Clearing flags on attachment: 347055

Committed r235089: <https://trac.webkit.org/changeset/235089>
Comment 12 WebKit Commit Bot 2018-08-20 12:22:34 PDT 
All reviewed patches have been landed.  Closing bug.