Bug 188516 - [ews-build] Separate queues for Builders and Testers - macOS Sierra
Summary: [ews-build] Separate queues for Builders and Testers - macOS Sierra
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: Other
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Aakash Jain
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2018-08-13 06:58 PDT by Aakash Jain
Modified: 2018-08-16 13:41 PDT (History)
6 users (show)

See Also:


Attachments
Proposed patch (3.84 KB, patch)
2018-08-13 07:11 PDT, Aakash Jain
lforschler: review-
Details | Formatted Diff | Diff
Updated patch (4.47 KB, patch)
2018-08-14 15:55 PDT, Aakash Jain
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Aakash Jain 2018-08-13 06:58:07 PDT
Currently EWS bots build and test on same machine. This is not very efficient. We should instead build (and upload) the archive and re-use it for multiple types of tests (e.g.: WK1, WK2, API tests). This would improve the overall system efficiency by reducing the number of builds while producing same kind of output. This would also improve the overall turn-around time to get EWS results after an engineer uploads a patch.

This bug tracks splitting macOS Sierra Release queues in builders and testers.
Comment 1 Aakash Jain 2018-08-13 07:11:26 PDT
Created attachment 347013 [details]
Proposed patch

This change results in a clear efficiency improvement. Instead of Building (compiling WebKit) on multiple queues (WK1 and WK2), Build would be done only on one queue (Builder) and it would be re-used on 3 queues (WK1, WK2, API-tests).

For each patch, we are saving WebKit compilation time twice. This would results in bots being more available and reduce the overall time engineers have to wait to get the EWS results after a patch is uploaded.

Sample runs:

macOS-Sierra-Release-Build-EWS: http://ews-build.webkit-uat.org/#/builders/25/builds/11
macOS-Sierra-Release-WK1-Tests-EWS: http://ews-build.webkit-uat.org/#/builders/26/builds/13
macOS-Sierra-Release-WK2-Tests-EWS: http://ews-build.webkit-uat.org/#/builders/27/builds/12
Comment 2 EWS Watchlist 2018-08-13 07:12:34 PDT Comment hidden (obsolete)
Comment 3 Lucas Forschler 2018-08-14 09:15:41 PDT
Comment on attachment 347013 [details]
Proposed patch

Mac OS is now called macOS...I think we should probably use 'macOS' everywhere, rather than 'Mac'. I could be convinced to use MacOS (capitol M) since it is the first letter of the class name. But, I would not oppose using lowercase. others may have a stronger opinion. Please ask around and see what others think.

Also, let's either fix the style errors, or override them for buildbot instances if they are false.
Comment 4 Aakash Jain 2018-08-14 15:54:55 PDT
(In reply to Lucas Forschler from comment #3)
> Mac OS is now called macOS...I think we should probably use 'macOS' everywhere, rather than 'Mac'.
Good point. I have changed to macOS everywhere in updated patch.

> Also, let's either fix the style errors, or override them for buildbot instances if they are false.
Filed https://bugs.webkit.org/show_bug.cgi?id=188584 to track style checker issue.
Comment 5 Aakash Jain 2018-08-14 15:55:39 PDT
Created attachment 347119 [details]
Updated patch
Comment 6 EWS Watchlist 2018-08-14 15:58:35 PDT
Attachment 347119 [details] did not pass style-queue:


ERROR: Tools/BuildSlaveSupport/ews-build/factories.py:139:  [macOSWK1Factory] Undefined variable 'RunWebKit1Tests'  [pylint/E0602] [5]
ERROR: Tools/BuildSlaveSupport/ews-build/factories.py:143:  [macOSWK2Factory] Undefined variable 'RunWebKitTests'  [pylint/E0602] [5]
Total errors found: 2 in 3 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 7 Lucas Forschler 2018-08-16 12:53:40 PDT
(In reply to Aakash Jain from comment #4)
> (In reply to Lucas Forschler from comment #3)
> > Mac OS is now called macOS...I think we should probably use 'macOS' everywhere, rather than 'Mac'.
> Good point. I have changed to macOS everywhere in updated patch.

can you file a bug to update other instances outside of this patch?

> 
> > Also, let's either fix the style errors, or override them for buildbot instances if they are false.
> Filed https://bugs.webkit.org/show_bug.cgi?id=188584 to track style checker
> issue.
Comment 8 Aakash Jain 2018-08-16 13:02:46 PDT
> can you file a bug to update other instances outside of this patch?
Done in: https://bugs.webkit.org/show_bug.cgi?id=188540
Comment 9 WebKit Commit Bot 2018-08-16 13:40:22 PDT
Comment on attachment 347119 [details]
Updated patch

Clearing flags on attachment: 347119

Committed r234951: <https://trac.webkit.org/changeset/234951>
Comment 10 WebKit Commit Bot 2018-08-16 13:40:23 PDT
All reviewed patches have been landed.  Closing bug.
Comment 11 Radar WebKit Bug Importer 2018-08-16 13:41:17 PDT
<rdar://problem/43394566>