Bug 188469 - [IntersectionObserver] Implement rootMargin parsing
Summary: [IntersectionObserver] Implement rootMargin parsing
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: WebKit Local Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Ali Juma
URL:
Keywords: InRadar
Depends on:
Blocks: 159475
  Show dependency tree / graph
 
Reported: 2018-08-10 07:00 PDT by Ali Juma
Modified: 2018-08-14 10:12 PDT (History)
10 users (show)

See Also:

Attachments
Patch (15.38 KB, patch)
2018-08-10 07:17 PDT, Ali Juma 		no flags Details | Formatted Diff | Diff
Follow-up fix (1.42 KB, patch)
2018-08-14 10:08 PDT, Ali Juma 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Ali Juma 2018-08-10 07:00:57 PDT 
Parse the constructor's rootMargin argument and throw an exception if it's invalid.
Comment 1 Ali Juma 2018-08-10 07:17:16 PDT 
Created attachment 346903 [details]
Patch
Comment 2 WebKit Commit Bot 2018-08-10 10:08:50 PDT 
Comment on attachment 346903 [details]
Patch

Clearing flags on attachment: 346903

Committed r234761: <https://trac.webkit.org/changeset/234761>
Comment 3 WebKit Commit Bot 2018-08-10 10:08:51 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 4 Radar WebKit Bug Importer 2018-08-10 10:09:19 PDT 
<rdar://problem/43146118>
Comment 5 Darin Adler 2018-08-14 09:33:25 PDT 
Comment on attachment 346903 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=346903&action=review

> Source/WebCore/page/IntersectionObserver.cpp:114
> +            stringBuilder.append("px", 2);

Oops, missed this in the initial review. This should instead be:

    stringBuilder.appendLiteral("px");
Comment 6 Ali Juma 2018-08-14 10:08:50 PDT 
Reopening to attach new patch.
Comment 7 Ali Juma 2018-08-14 10:08:52 PDT 
Created attachment 347087 [details]
Follow-up fix

Address review comment
Comment 8 Ali Juma 2018-08-14 10:12:22 PDT 
Comment on attachment 347087 [details]
Follow-up fix

Clearing flags on attachment: 347087

Committed r234851: <https://trac.webkit.org/changeset/234851>
Comment 9 Ali Juma 2018-08-14 10:12:24 PDT 
All reviewed patches have been landed.  Closing bug.