Bug 188465 - [GTK][WPE] WebDriver: do not use default browser arguments when browser binary has been provided
Summary: [GTK][WPE] WebDriver: do not use default browser arguments when browser binar...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebDriver (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords: Gtk, InRadar
Depends on:
Blocks:
 
Reported: 2018-08-10 00:47 PDT by Carlos Garcia Campos
Modified: 2018-08-10 01:18 PDT (History)
4 users (show)

See Also:


Attachments
Patch (4.01 KB, patch)
2018-08-10 00:50 PDT, Carlos Garcia Campos
zan: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Carlos Garcia Campos 2018-08-10 00:47:07 PDT
We only want to use --automation when no options or no browser binary is provided, because we fallback to MiniBrowser and we know it needs --automation flag.
Comment 1 Carlos Garcia Campos 2018-08-10 00:50:14 PDT
Created attachment 346899 [details]
Patch
Comment 2 Carlos Garcia Campos 2018-08-10 01:17:18 PDT
Committed r234753: <https://trac.webkit.org/changeset/234753>
Comment 3 Radar WebKit Bug Importer 2018-08-10 01:18:18 PDT
<rdar://problem/43131428>