Bug 188459 – Cleanup: Remove unnecessary code to resume animations from CachedFrameBase::restore()

• Status: RESOLVED
• Resolution: FIXED
• Component: WebCore Misc.

[Daniel Bates]

CachedFrameBase::restore() starts off as:

[[
void CachedFrameBase::restore()
{
    ASSERT(m_document->view() == m_view);
    ...
    if (RuntimeEnabledFeatures::sharedFeatures().webAnimationsCSSIntegrationEnabled())
        m_document->timeline().resumeAnimations();
    else
        frame.animation().resumeAnimationsForDocument(m_document.get());

    m_document->resume(ReasonForSuspension::PageCache);
...
]]]
<https://trac.webkit.org/browser/trunk/Source/WebCore/history/CachedFrame.cpp?rev=234703#L88>

And Document::resume() starts off as:

[[
void Document::resume(ReasonForSuspension reason)
{
    if (!m_isSuspended)
        return;

    ...

    if (RuntimeEnabledFeatures::sharedFeatures().webAnimationsCSSIntegrationEnabled())
        timeline().resumeAnimations();
    else
        m_frame->animation().resumeAnimationsForDocument(this);

...
]]
<https://trac.webkit.org/browser/trunk/Source/WebCore/dom/Document.cpp?rev=234703#L4942>

It is not necessary for CachedFrameBase::restore() to explicitly resume animations because Document will do this for us when Document::resume() is called.

[Daniel Bates]

Created attachment 346877 [details]
Patch

[Daniel Bates]

Comment on attachment 346877 [details]
Patch

Clearing flags on attachment: 346877

Committed r234771: <https://trac.webkit.org/changeset/234771>

[Daniel Bates]

All reviewed patches have been landed.  Closing bug.

[Radar WebKit Bug Importer]

<rdar://problem/43158193>