Bug 188454 - [LayoutTests] Test case which committed on r175053 was wrong.
Summary: [LayoutTests] Test case which committed on r175053 was wrong.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Basuke Suzuki
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2018-08-09 15:57 PDT by Basuke Suzuki
Modified: 2018-08-09 22:14 PDT (History)
11 users (show)

See Also:


Attachments
fix (6.03 KB, patch)
2018-08-09 16:02 PDT, Basuke Suzuki
no flags Details | Formatted Diff | Diff
Archive of layout-test-results from ews115 for mac-sierra (3.08 MB, application/zip)
2018-08-09 17:42 PDT, EWS Watchlist
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Basuke Suzuki 2018-08-09 15:57:38 PDT
It was originally committed on https://bugs.webkit.org/show_bug.cgi?id=136938 and has kept unchanged, but the test case uses non-existing redirect.php scripts which was removed a few months before than this bug. Also result was compared to wrong values.
Comment 1 Basuke Suzuki 2018-08-09 16:02:00 PDT
Created attachment 346868 [details]
fix
Comment 2 Basuke Suzuki 2018-08-09 16:02:50 PDT
I confirmed the result is same with current Chrome.
Comment 3 Basuke Suzuki 2018-08-09 16:07:00 PDT
Comment on attachment 346868 [details]
fix

View in context: https://bugs.webkit.org/attachment.cgi?id=346868&action=review

> LayoutTests/http/tests/xmlhttprequest/cross-origin-redirect-responseURL-expected.txt:23
> +PASS responseURL is ""

redirect fails so that responseURL should be empty. Also there's no readyState 2,3 happens.

> LayoutTests/http/tests/xmlhttprequest/cross-origin-redirect-responseURL-expected.txt:31
> +PASS responseURL is ""

Ditto.

> LayoutTests/http/tests/xmlhttprequest/cross-origin-redirect-responseURL.html:-37
> -runTest('resources/redirect.php?url=http://127.0.0.1:8000/xmlhttprequest/resources/access-control-basic-allow.cgi', 'text').then(function(req) {

xmlhttprequest/resources/redirect.php was moved to /resources/ with this bug. https://bugs.webkit.org/show_bug.cgi?id=119641
Comment 4 EWS Watchlist 2018-08-09 17:42:35 PDT
Comment on attachment 346868 [details]
fix

Attachment 346868 [details] did not pass mac-debug-ews (mac):
Output: https://webkit-queues.webkit.org/results/8813588

New failing tests:
fast/loader/redirect-to-invalid-url-using-meta-refresh-calls-policy-delegate.html
Comment 5 EWS Watchlist 2018-08-09 17:42:37 PDT
Created attachment 346879 [details]
Archive of layout-test-results from ews115 for mac-sierra

The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews115  Port: mac-sierra  Platform: Mac OS X 10.12.6
Comment 6 WebKit Commit Bot 2018-08-09 22:13:53 PDT
Comment on attachment 346868 [details]
fix

Clearing flags on attachment: 346868

Committed r234751: <https://trac.webkit.org/changeset/234751>
Comment 7 WebKit Commit Bot 2018-08-09 22:13:55 PDT
All reviewed patches have been landed.  Closing bug.
Comment 8 Radar WebKit Bug Importer 2018-08-09 22:14:25 PDT
<rdar://problem/43126703>