Bug 188434 – [GTK] Several history interface tests are flaky

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKitGTK

[Miguel Gomez]

imported/w3c/web-platform-tests/html/browsers/history/the-history-interface/history_forward_1.html [ Failure Pass ]
imported/w3c/web-platform-tests/html/browsers/history/the-history-interface/history_go_no_argument.html [ Failure Pass ]
imported/w3c/web-platform-tests/html/browsers/history/the-history-interface/history_go_to_uri.html [ Failure Pass ]
imported/w3c/web-platform-tests/html/browsers/history/the-history-interface/history_go_undefined.html [ Failure Pass ]
imported/w3c/web-platform-tests/html/browsers/history/the-history-interface/traverse_the_history_5.html [ Failure Pass ]

Every now and then these tests fail on the first run and pass on the second one.
When failing, the output diff suggests that it's because of a timeout running the tests. These are the diffs:

imported/w3c/web-platform-tests/html/browsers/history/the-history-interface/history_forward_1.html [ Failure Pass ]

--- /home/slave/webkitgtk/gtk-linux-64-release-tests/build/layout-test-results/imported/w3c/web-platform-tests/html/browsers/history/the-history-interface/history_forward_1-expected.txt
+++ /home/slave/webkitgtk/gtk-linux-64-release-tests/build/layout-test-results/imported/w3c/web-platform-tests/html/browsers/history/the-history-interface/history_forward_1-actual.txt
@@ -4,5 +4,5 @@
 main frame - has 1 onunload handler(s)
 main frame - has 1 onunload handler(s)
 
-PASS history.forward() with session history 
+TIMEOUT history.forward() with session history Test timed out


imported/w3c/web-platform-tests/html/browsers/history/the-history-interface/history_go_no_argument.html [ Failure Pass ]

--- /home/slave/webkitgtk/gtk-linux-64-release-tests/build/layout-test-results/imported/w3c/web-platform-tests/html/browsers/history/the-history-interface/history_go_no_argument-expected.txt
+++ /home/slave/webkitgtk/gtk-linux-64-release-tests/build/layout-test-results/imported/w3c/web-platform-tests/html/browsers/history/the-history-interface/history_go_no_argument-actual.txt
@@ -1,8 +1,7 @@
-main frame - has 1 onunload handler(s)
 main frame - has 1 onunload handler(s)
 main frame - has 1 onunload handler(s)
 main frame - has 1 onunload handler(s)
 main frame - has 1 onunload handler(s)
 
-PASS history.go() 
+FAIL history.go() assert_array_equals: Pages opened during history navigation lengths differ, expected 3 got 2
 

imported/w3c/web-platform-tests/html/browsers/history/the-history-interface/history_go_to_uri.html [ Failure Pass ]

--- /home/slave/webkitgtk/gtk-linux-64-release-tests/build/layout-test-results/imported/w3c/web-platform-tests/html/browsers/history/the-history-interface/history_go_to_uri-expected.txt
+++ /home/slave/webkitgtk/gtk-linux-64-release-tests/build/layout-test-results/imported/w3c/web-platform-tests/html/browsers/history/the-history-interface/history_go_to_uri-actual.txt
@@ -1,8 +1,7 @@
-main frame - has 1 onunload handler(s)
 main frame - has 1 onunload handler(s)
 main frame - has 1 onunload handler(s)
 main frame - has 1 onunload handler(s)
 main frame - has 1 onunload handler(s)
 
-PASS history.go() negative tests 
+FAIL history.go() negative tests assert_array_equals: Pages opened during history navigation lengths differ, expected 3 got 2


imported/w3c/web-platform-tests/html/browsers/history/the-history-interface/history_go_undefined.html [ Failure Pass ]

--- /home/slave/webkitgtk/gtk-linux-64-release-tests/build/layout-test-results/imported/w3c/web-platform-tests/html/browsers/history/the-history-interface/history_go_undefined-expected.txt
+++ /home/slave/webkitgtk/gtk-linux-64-release-tests/build/layout-test-results/imported/w3c/web-platform-tests/html/browsers/history/the-history-interface/history_go_undefined-actual.txt
@@ -4,5 +4,5 @@
 main frame - has 1 onunload handler(s)
 main frame - has 1 onunload handler(s)
 
-FAIL history.forward() with session history assert_array_equals: Pages opened during history navigation property 2, expected 2 but got 3
+TIMEOUT history.forward() with session history Test timed out

imported/w3c/web-platform-tests/html/browsers/history/the-history-interface/traverse_the_history_5.html [ Failure Pass ]

--- /home/slave/webkitgtk/gtk-linux-64-release-tests/build/layout-test-results/imported/w3c/web-platform-tests/html/browsers/history/the-history-interface/traverse_the_history_5-expected.txt
+++ /home/slave/webkitgtk/gtk-linux-64-release-tests/build/layout-test-results/imported/w3c/web-platform-tests/html/browsers/history/the-history-interface/traverse_the_history_5-actual.txt
@@ -1,10 +1,8 @@
-main frame - has 1 onunload handler(s)
-main frame - has 1 onunload handler(s)
 main frame - has 1 onunload handler(s)
 main frame - has 1 onunload handler(s)
 main frame - has 1 onunload handler(s)
 main frame - has 1 onunload handler(s)
 main frame - has 1 onunload handler(s)
 
-FAIL Multiple history traversals, last would be aborted assert_array_equals: Pages opened during history navigation property 1, expected 5 but got 4
+TIMEOUT Multiple history traversals, last would be aborted Test timed out

[Diego Pino]

The test(s) filed under this bug have been consistently passing for the last 4000 revisions. Marking bug as fixed.

Committed r263254: <https://trac.webkit.org/changeset/263254>