Array.prototype.sort should call @toLength instead of ">>> 0"
Created attachment 346816 [details] Patch
Comment on attachment 346816 [details] Patch Attachment 346816 [details] did not pass mac-ews (mac): Output: https://webkit-queues.webkit.org/results/8805778 New failing tests: sputnik/Conformance/15_Native_Objects/15.4_Array/15.4.4/15.4.4.11_Array_prototype_sort/S15.4.4.11_A4_T1.html sputnik/Conformance/15_Native_Objects/15.4_Array/15.4.4/15.4.4.11_Array_prototype_sort/S15.4.4.11_A4_T2.html sputnik/Conformance/15_Native_Objects/15.4_Array/15.4.4/15.4.4.11_Array_prototype_sort/S15.4.4.11_A4_T3.html
Created attachment 346819 [details] Archive of layout-test-results from ews102 for mac-sierra The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: ews102 Port: mac-sierra Platform: Mac OS X 10.12.6
Comment on attachment 346816 [details] Patch Attachment 346816 [details] did not pass mac-wk2-ews (mac-wk2): Output: https://webkit-queues.webkit.org/results/8805797 New failing tests: sputnik/Conformance/15_Native_Objects/15.4_Array/15.4.4/15.4.4.11_Array_prototype_sort/S15.4.4.11_A4_T1.html sputnik/Conformance/15_Native_Objects/15.4_Array/15.4.4/15.4.4.11_Array_prototype_sort/S15.4.4.11_A4_T2.html sputnik/Conformance/15_Native_Objects/15.4_Array/15.4.4/15.4.4.11_Array_prototype_sort/S15.4.4.11_A4_T3.html
Created attachment 346821 [details] Archive of layout-test-results from ews104 for mac-sierra-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: ews104 Port: mac-sierra-wk2 Platform: Mac OS X 10.12.6
Comment on attachment 346816 [details] Patch Attachment 346816 [details] did not pass mac-debug-ews (mac): Output: https://webkit-queues.webkit.org/results/8805836 New failing tests: sputnik/Conformance/15_Native_Objects/15.4_Array/15.4.4/15.4.4.11_Array_prototype_sort/S15.4.4.11_A4_T1.html sputnik/Conformance/15_Native_Objects/15.4_Array/15.4.4/15.4.4.11_Array_prototype_sort/S15.4.4.11_A4_T2.html sputnik/Conformance/15_Native_Objects/15.4_Array/15.4.4/15.4.4.11_Array_prototype_sort/S15.4.4.11_A4_T3.html
Created attachment 346822 [details] Archive of layout-test-results from ews112 for mac-sierra The attached test failures were seen while running run-webkit-tests on the mac-debug-ews. Bot: ews112 Port: mac-sierra Platform: Mac OS X 10.12.6
Created attachment 346823 [details] Patch
Created attachment 346824 [details] Patch
Comment on attachment 346824 [details] Patch Attachment 346824 [details] did not pass mac-ews (mac): Output: https://webkit-queues.webkit.org/results/8806499 New failing tests: sputnik/Conformance/15_Native_Objects/15.4_Array/15.4.4/15.4.4.11_Array_prototype_sort/S15.4.4.11_A4_T2.html sputnik/Conformance/15_Native_Objects/15.4_Array/15.4.4/15.4.4.11_Array_prototype_sort/S15.4.4.11_A4_T3.html
Created attachment 346825 [details] Archive of layout-test-results from ews103 for mac-sierra The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: ews103 Port: mac-sierra Platform: Mac OS X 10.12.6
Comment on attachment 346824 [details] Patch Attachment 346824 [details] did not pass mac-wk2-ews (mac-wk2): Output: https://webkit-queues.webkit.org/results/8806544 New failing tests: sputnik/Conformance/15_Native_Objects/15.4_Array/15.4.4/15.4.4.11_Array_prototype_sort/S15.4.4.11_A4_T2.html sputnik/Conformance/15_Native_Objects/15.4_Array/15.4.4/15.4.4.11_Array_prototype_sort/S15.4.4.11_A4_T3.html
Created attachment 346827 [details] Archive of layout-test-results from ews104 for mac-sierra-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: ews104 Port: mac-sierra-wk2 Platform: Mac OS X 10.12.6
Comment on attachment 346824 [details] Patch Attachment 346824 [details] did not pass mac-debug-ews (mac): Output: https://webkit-queues.webkit.org/results/8806564 New failing tests: sputnik/Conformance/15_Native_Objects/15.4_Array/15.4.4/15.4.4.11_Array_prototype_sort/S15.4.4.11_A4_T2.html sputnik/Conformance/15_Native_Objects/15.4_Array/15.4.4/15.4.4.11_Array_prototype_sort/S15.4.4.11_A4_T3.html
Created attachment 346828 [details] Archive of layout-test-results from ews117 for mac-sierra The attached test failures were seen while running run-webkit-tests on the mac-debug-ews. Bot: ews117 Port: mac-sierra Platform: Mac OS X 10.12.6
Comment on attachment 346824 [details] Patch Attachment 346824 [details] did not pass ios-sim-ews (ios-simulator-wk2): Output: https://webkit-queues.webkit.org/results/8806589 New failing tests: sputnik/Conformance/15_Native_Objects/15.4_Array/15.4.4/15.4.4.11_Array_prototype_sort/S15.4.4.11_A4_T2.html sputnik/Conformance/15_Native_Objects/15.4_Array/15.4.4/15.4.4.11_Array_prototype_sort/S15.4.4.11_A4_T3.html
Created attachment 346829 [details] Archive of layout-test-results from ews122 for ios-simulator-wk2 The attached test failures were seen while running run-webkit-tests on the ios-sim-ews. Bot: ews122 Port: ios-simulator-wk2 Platform: Mac OS X 10.13.4
Created attachment 346842 [details] Patch
Comment on attachment 346842 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=346842&action=review > JSTests/ChangeLog:8 > + * test262/expectations.yaml: can we add a non test262 test as well.
Comment on attachment 346842 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=346842&action=review >> JSTests/ChangeLog:8 >> + * test262/expectations.yaml: > > can we add a non test262 test as well. That seems unnecessary. Unless the spec changes here I don't see why we would start failing this test again and not flag it.
(In reply to Keith Miller from comment #20) > Comment on attachment 346842 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=346842&action=review > > >> JSTests/ChangeLog:8 > >> + * test262/expectations.yaml: > > > > can we add a non test262 test as well. > > That seems unnecessary. Unless the spec changes here I don't see why we > would start failing this test again and not flag it. 👍🏼
Committed r234728: <https://trac.webkit.org/changeset/234728>
<rdar://problem/43101740>