Bug 188427 - Yet more crashes in MobileSafari under -[WKFormInputSession setSuggestions:]
Summary: Yet more crashes in MobileSafari under -[WKFormInputSession setSuggestions:]
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Tim Horton
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2018-08-08 18:40 PDT by Tim Horton
Modified: 2018-08-08 21:36 PDT (History)
2 users (show)

See Also:

Attachments
Patch (4.10 KB, patch)
2018-08-08 18:41 PDT, Tim Horton 		wenson_hsieh: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Tim Horton 2018-08-08 18:40:57 PDT 
Yet more crashes in MobileSafari under -[WKFormInputSession setSuggestions:]
Comment 1 Tim Horton 2018-08-08 18:41:19 PDT 
Created attachment 346809 [details]
Patch
Comment 2 Tim Horton 2018-08-08 18:41:21 PDT 
<rdar://problem/43064672>
Comment 3 Wenson Hsieh 2018-08-08 19:02:24 PDT 
Comment on attachment 346809 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=346809&action=review

> Source/WebKit/ChangeLog:15
> +        Belt-and-suspenders fix: use ObjCWeakPtr for WKFormInputSession's WKContentView reference.

ObjCWeakPtr => WeakObjCPtr
Comment 4 Tim Horton 2018-08-08 21:36:49 PDT 
https://trac.webkit.org/changeset/234719/webkit