Bug 188419 - Followup (r234683): Element::getAttribute() should return the first non-null attribute value
Summary: Followup (r234683): Element::getAttribute() should return the first non-null ...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: SVG (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Said Abou-Hallawa
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2018-08-08 14:30 PDT by Said Abou-Hallawa
Modified: 2018-08-13 09:40 PDT (History)
10 users (show)

See Also:

Attachments
Patch (5.22 KB, patch)
2018-08-08 14:44 PDT, Said Abou-Hallawa 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Said Abou-Hallawa 2018-08-08 14:30:07 PDT 
This is a follow up for Darin's comments in https://bugs.webkit.org/show_bug.cgi?id=153854.

In r234683, a new template function Element::getAttribute() was added to return the first non-empty attribute value. The goal was to handle deprecated attributes in a clean way.

Element::getAttribute() should return the first non-null attribute value since an empty string is a legitimate attribute value.
Comment 1 Said Abou-Hallawa 2018-08-08 14:44:55 PDT 
Created attachment 346799 [details]
Patch
Comment 2 WebKit Commit Bot 2018-08-13 09:39:22 PDT 
Comment on attachment 346799 [details]
Patch

Clearing flags on attachment: 346799

Committed r234803: <https://trac.webkit.org/changeset/234803>
Comment 3 WebKit Commit Bot 2018-08-13 09:39:23 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 4 Radar WebKit Bug Importer 2018-08-13 09:40:29 PDT 
<rdar://problem/43236643>