RESOLVED FIXED 188418
Fix possible null dereference in WebBackForwardList::restoreFromState 
https://bugs.webkit.org/show_bug.cgi?id=188418
Summary Fix possible null dereference in WebBackForwardList::restoreFromState
Alex Christensen
Reported 2018-08-08 14:18:28 PDT
Fix possible null dereference in WebBackForwardList::restoreFromState
Attachments
Patch (1.23 KB, patch)
2018-08-08 14:18 PDT, Alex Christensen 		no flags
DetailsFormatted DiffDiff
Patch (2.92 KB, patch)
2018-08-08 15:05 PDT, Alex Christensen 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Alex Christensen
Comment 1 2018-08-08 14:18:51 PDT
Created attachment 346795 [details] Patch
Alex Christensen
Comment 2 2018-08-08 14:18:53 PDT
<rdar://problem/42531726>
Chris Dumez
Comment 3 2018-08-08 14:44:15 PDT
Comment on attachment 346795 [details] Patch I think it is fine to make this change in WebKit. However, let's confirm that it does not crash later on (or that Safari is not visually broken) after this fix before closing <rdar://problem/42531726>, since we have reproduction steps.
Chris Dumez
Comment 4 2018-08-08 14:45:49 PDT
Comment on attachment 346795 [details] Patch Actually, hold on. We should have an API test.
Chris Dumez
Comment 5 2018-08-08 15:03:26 PDT
<rdar://problem/43065730>
Alex Christensen
Comment 6 2018-08-08 15:05:54 PDT
Created attachment 346802 [details] Patch
Chris Dumez
Comment 7 2018-08-08 15:29:23 PDT
Comment on attachment 346802 [details] Patch r=me
WebKit Commit Bot
Comment 8 2018-08-08 15:58:27 PDT
Comment on attachment 346802 [details] Patch Clearing flags on attachment: 346802 Committed r234714: <https://trac.webkit.org/changeset/234714>
WebKit Commit Bot
Comment 9 2018-08-08 15:58:29 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.