Bug 188418 - Fix possible null dereference in WebBackForwardList::restoreFromState
Summary: Fix possible null dereference in WebBackForwardList::restoreFromState
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Alex Christensen
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2018-08-08 14:18 PDT by Alex Christensen
Modified: 2018-08-08 15:58 PDT (History)
4 users (show)

See Also:

Attachments
Patch (1.23 KB, patch)
2018-08-08 14:18 PDT, Alex Christensen 		no flags Details | Formatted Diff | Diff
Patch (2.92 KB, patch)
2018-08-08 15:05 PDT, Alex Christensen 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Alex Christensen 2018-08-08 14:18:28 PDT 
Fix possible null dereference in WebBackForwardList::restoreFromState
Comment 1 Alex Christensen 2018-08-08 14:18:51 PDT 
Created attachment 346795 [details]
Patch
Comment 2 Alex Christensen 2018-08-08 14:18:53 PDT 
<rdar://problem/42531726>
Comment 3 Chris Dumez 2018-08-08 14:44:15 PDT 
Comment on attachment 346795 [details]
Patch

I think it is fine to make this change in WebKit. However, let's confirm that it does not crash later on (or that Safari is not visually broken) after this fix before closing <rdar://problem/42531726>, since we have reproduction steps.
Comment 4 Chris Dumez 2018-08-08 14:45:49 PDT 
Comment on attachment 346795 [details]
Patch

Actually, hold on. We should have an API test.
Comment 5 Chris Dumez 2018-08-08 15:03:26 PDT 
<rdar://problem/43065730>
Comment 6 Alex Christensen 2018-08-08 15:05:54 PDT 
Created attachment 346802 [details]
Patch
Comment 7 Chris Dumez 2018-08-08 15:29:23 PDT 
Comment on attachment 346802 [details]
Patch

r=me
Comment 8 WebKit Commit Bot 2018-08-08 15:58:27 PDT 
Comment on attachment 346802 [details]
Patch

Clearing flags on attachment: 346802

Committed r234714: <https://trac.webkit.org/changeset/234714>
Comment 9 WebKit Commit Bot 2018-08-08 15:58:29 PDT 
All reviewed patches have been landed.  Closing bug.