Bug 188416 - Import WPTs for IntersectionObserver
Summary: Import WPTs for IntersectionObserver
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Ali Juma
URL:
Keywords: InRadar
Depends on:
Blocks: 159475
  Show dependency tree / graph
 
Reported: 2018-08-08 13:47 PDT by Ali Juma
Modified: 2018-08-09 06:37 PDT (History)
6 users (show)

See Also:

Attachments
Patch (119.42 KB, patch)
2018-08-08 13:53 PDT, Ali Juma 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Ali Juma 2018-08-08 13:47:15 PDT 
Import WPTs for IntersectionObserver
Comment 1 Ali Juma 2018-08-08 13:53:30 PDT 
Created attachment 346790 [details]
Patch
Comment 2 Simon Fraser (smfr) 2018-08-08 14:48:50 PDT 
Comment on attachment 346790 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=346790&action=review

> Source/WebKitLegacy/mac/WebView/WebPreferencesPrivate.h:580
> +- (void)setIntersectionObserverEnabled:(BOOL)flag;
> +- (BOOL)intersectionObserverEnabled;

I don't think you need this. You can to through the (admittedly bad) experimental features API.

> Tools/DumpRenderTree/mac/DumpRenderTree.mm:870
> +    [preferences setIntersectionObserverEnabled:YES];

We really need to make this automatic. Sad that you have to do this.
Comment 3 Ali Juma 2018-08-08 14:59:03 PDT 
Comment on attachment 346790 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=346790&action=review

>> Source/WebKitLegacy/mac/WebView/WebPreferencesPrivate.h:580
>> +- (BOOL)intersectionObserverEnabled;
> 
> I don't think you need this. You can to through the (admittedly bad) experimental features API.

This in WK1 (exposing the method that DumpRenderTree needs to call), so there's no experimental features API afaik.
Comment 4 WebKit Commit Bot 2018-08-09 06:36:58 PDT 
Comment on attachment 346790 [details]
Patch

Clearing flags on attachment: 346790

Committed r234723: <https://trac.webkit.org/changeset/234723>
Comment 5 WebKit Commit Bot 2018-08-09 06:36:59 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 6 Radar WebKit Bug Importer 2018-08-09 06:37:30 PDT 
<rdar://problem/43092053>