These tests are showing flaky nature on GTK port imported/w3c/web-platform-tests/workers/interfaces/WorkerGlobalScope/onerror/exception-in-onerror.html imported/w3c/web-platform-tests/workers/WorkerGlobalScope_ErrorEvent_message.htm imported/w3c/web-platform-tests/workers/interfaces/WorkerGlobalScope/onerror/exception-in-onerror.html imported/w3c/web-platform-tests/workers/WorkerGlobalScope_ErrorEvent_colno.htm imported/w3c/web-platform-tests/workers/WorkerGlobalScope_ErrorEvent_filename.htm imported/w3c/web-platform-tests/workers/WorkerGlobalScope_ErrorEvent_filename.htm imported/w3c/web-platform-tests/workers/WorkerGlobalScope_ErrorEvent_lineno.htm
Created attachment 346778 [details] Patch
Attachment 346778 [details] did not pass style-queue: ERROR: LayoutTests/platform/gtk/TestExpectations:1936: Path does not exist. [test/expectations] [5] ERROR: /Volumes/Data/StyleQueue/WebKit/LayoutTests/platform/gtk/TestExpectations:1936: Path does not exist. [test/expectations] [5] ERROR: /Volumes/Data/StyleQueue/WebKit/LayoutTests/platform/gtk/TestExpectations:1941: Duplicate or ambiguous entry lines LayoutTests/platform/gtk/TestExpectations:1940 and LayoutTests/platform/gtk/TestExpectations:1941. [test/expectations] [5] Total errors found: 3 in 2 files If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 346778 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=346778&action=review > LayoutTests/ChangeLog:3 > + Wokers related flaky tests Workers (with a R). Maybe rename the bug "[GTK] Mark some Web workers tests as flaky". > LayoutTests/platform/gtk/TestExpectations:1936 > +webkit.org/b/188412 eb-platform-tests/workers/interfaces/WorkerGlobalScope/onerror/exception-in-onerror.html [ Failure Pass ] This line looks strange, I guess that's why the style fails.
Comment on attachment 346778 [details] Patch Yeah the errors need fixed: > ERROR: LayoutTests/platform/gtk/TestExpectations:1936: Path does not exist. > [test/expectations] [5] > ERROR: > /Volumes/Data/StyleQueue/WebKit/LayoutTests/platform/gtk/TestExpectations: > 1936: Path does not exist. [test/expectations] [5] > ERROR: > /Volumes/Data/StyleQueue/WebKit/LayoutTests/platform/gtk/TestExpectations: > 1941: Duplicate or ambiguous entry lines > LayoutTests/platform/gtk/TestExpectations:1940 and > LayoutTests/platform/gtk/TestExpectations:1941. [test/expectations] [5] > Total errors found: 3 in 2 files
Created attachment 346835 [details] Patch
Comment on attachment 346835 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=346835&action=review > LayoutTests/ChangeLog:3 > + Wokers related flaky tests This line should be the title of the bug: "[GTK] Mark some Web workers tests as flaky" Also note wokers is misspelled > LayoutTests/platform/gtk/TestExpectations:1936 > +webkit.org/b/188412 imported/w3c/web-platform-tests/workers/interfaces/WorkerGlobalScope/onerror/exception-in-onerror.html [ Failure Pass ] This should point to a different bug (which you can report now) to fix the issue, since we want TestExpectations to point to open unresolved bugs. This bug #188412 is going to be closed by commit-queue as soon as your patch is committed. > LayoutTests/platform/gtk/TestExpectations:1942 > + > + No need for two blank lines here. One will do.
Created attachment 347017 [details] Patch
Comment on attachment 347017 [details] Patch r- since Michael's comment "This should point to a different bug (which you can report now) to fix the issue," has not been addressed.