WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
NEW
188412
[GTK] Mark some Web workers tests as flaky
https://bugs.webkit.org/show_bug.cgi?id=188412
Summary
[GTK] Mark some Web workers tests as flaky
darshan
Reported
2018-08-08 10:50:12 PDT
These tests are showing flaky nature on GTK port imported/w3c/web-platform-tests/workers/interfaces/WorkerGlobalScope/onerror/exception-in-onerror.html imported/w3c/web-platform-tests/workers/WorkerGlobalScope_ErrorEvent_message.htm imported/w3c/web-platform-tests/workers/interfaces/WorkerGlobalScope/onerror/exception-in-onerror.html imported/w3c/web-platform-tests/workers/WorkerGlobalScope_ErrorEvent_colno.htm imported/w3c/web-platform-tests/workers/WorkerGlobalScope_ErrorEvent_filename.htm imported/w3c/web-platform-tests/workers/WorkerGlobalScope_ErrorEvent_filename.htm imported/w3c/web-platform-tests/workers/WorkerGlobalScope_ErrorEvent_lineno.htm
Attachments
Patch
(2.23 KB, patch)
2018-08-08 11:05 PDT
,
darshan
no flags
Details
Formatted Diff
Diff
Patch
(1.99 KB, patch)
2018-08-09 08:03 PDT
,
darshan
no flags
Details
Formatted Diff
Diff
Patch
(2.01 KB, patch)
2018-08-13 10:50 PDT
,
darshan
fred.wang
: review-
Details
Formatted Diff
Diff
Show Obsolete
(2)
View All
Add attachment
proposed patch, testcase, etc.
darshan
Comment 1
2018-08-08 11:05:24 PDT
Created
attachment 346778
[details]
Patch
EWS Watchlist
Comment 2
2018-08-08 11:06:30 PDT
Attachment 346778
[details]
did not pass style-queue: ERROR: LayoutTests/platform/gtk/TestExpectations:1936: Path does not exist. [test/expectations] [5] ERROR: /Volumes/Data/StyleQueue/WebKit/LayoutTests/platform/gtk/TestExpectations:1936: Path does not exist. [test/expectations] [5] ERROR: /Volumes/Data/StyleQueue/WebKit/LayoutTests/platform/gtk/TestExpectations:1941: Duplicate or ambiguous entry lines LayoutTests/platform/gtk/TestExpectations:1940 and LayoutTests/platform/gtk/TestExpectations:1941. [test/expectations] [5] Total errors found: 3 in 2 files If any of these errors are false positives, please file a bug against check-webkit-style.
Frédéric Wang (:fredw)
Comment 3
2018-08-08 14:19:05 PDT
Comment on
attachment 346778
[details]
Patch View in context:
https://bugs.webkit.org/attachment.cgi?id=346778&action=review
> LayoutTests/ChangeLog:3 > + Wokers related flaky tests
Workers (with a R). Maybe rename the bug "[GTK] Mark some Web workers tests as flaky".
> LayoutTests/platform/gtk/TestExpectations:1936 > +
webkit.org/b/188412
eb-platform-tests/workers/interfaces/WorkerGlobalScope/onerror/exception-in-onerror.html [ Failure Pass ]
This line looks strange, I guess that's why the style fails.
Michael Catanzaro
Comment 4
2018-08-08 15:35:14 PDT
Comment on
attachment 346778
[details]
Patch Yeah the errors need fixed:
> ERROR: LayoutTests/platform/gtk/TestExpectations:1936: Path does not exist. > [test/expectations] [5] > ERROR: > /Volumes/Data/StyleQueue/WebKit/LayoutTests/platform/gtk/TestExpectations: > 1936: Path does not exist. [test/expectations] [5] > ERROR: > /Volumes/Data/StyleQueue/WebKit/LayoutTests/platform/gtk/TestExpectations: > 1941: Duplicate or ambiguous entry lines > LayoutTests/platform/gtk/TestExpectations:1940 and > LayoutTests/platform/gtk/TestExpectations:1941. [test/expectations] [5] > Total errors found: 3 in 2 files
darshan
Comment 5
2018-08-09 08:03:02 PDT
Created
attachment 346835
[details]
Patch
Michael Catanzaro
Comment 6
2018-08-09 10:01:57 PDT
Comment on
attachment 346835
[details]
Patch View in context:
https://bugs.webkit.org/attachment.cgi?id=346835&action=review
> LayoutTests/ChangeLog:3 > + Wokers related flaky tests
This line should be the title of the bug: "[GTK] Mark some Web workers tests as flaky" Also note wokers is misspelled
> LayoutTests/platform/gtk/TestExpectations:1936 > +
webkit.org/b/188412
imported/w3c/web-platform-tests/workers/interfaces/WorkerGlobalScope/onerror/exception-in-onerror.html [ Failure Pass ]
This should point to a different bug (which you can report now) to fix the issue, since we want TestExpectations to point to open unresolved bugs. This
bug #188412
is going to be closed by commit-queue as soon as your patch is committed.
> LayoutTests/platform/gtk/TestExpectations:1942 > + > +
No need for two blank lines here. One will do.
darshan
Comment 7
2018-08-13 10:50:43 PDT
Created
attachment 347017
[details]
Patch
Frédéric Wang (:fredw)
Comment 8
2018-09-24 01:11:32 PDT
Comment on
attachment 347017
[details]
Patch r- since Michael's comment "This should point to a different bug (which you can report now) to fix the issue," has not been addressed.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug