Bug 188405 - [Nicosia] Add the Nicosia-specific PlatformLayer type alias
Summary: [Nicosia] Add the Nicosia-specific PlatformLayer type alias
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Zan Dobersek
URL:
Keywords: InRadar
Depends on:
Blocks: 187385
  Show dependency treegraph
 
Reported: 2018-08-08 00:48 PDT by Zan Dobersek
Modified: 2018-08-08 13:54 PDT (History)
12 users (show)

See Also:


Attachments
Patch (34.17 KB, patch)
2018-08-08 01:20 PDT, Zan Dobersek
no flags Details | Formatted Diff | Diff
Patch for landing (34.17 KB, patch)
2018-08-08 02:30 PDT, Zan Dobersek
no flags Details | Formatted Diff | Diff
WinCairo build fix (1.13 KB, patch)
2018-08-08 11:36 PDT, Don Olmstead
no flags Details | Formatted Diff | Diff
Build fix (1.13 KB, patch)
2018-08-08 12:27 PDT, Don Olmstead
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Zan Dobersek 2018-08-08 00:48:15 PDT
[Nicosia] Add the Nicosia-specific PlatformLayer type alias
Comment 1 Zan Dobersek 2018-08-08 01:20:52 PDT
Created attachment 346759 [details]
Patch
Comment 2 EWS Watchlist 2018-08-08 01:22:54 PDT
Attachment 346759 [details] did not pass style-queue:


ERROR: Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamerBase.cpp:857:  More than one command on the same line  [whitespace/newline] [4]
Total errors found: 1 in 14 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Carlos Garcia Campos 2018-08-08 01:43:36 PDT
Comment on attachment 346759 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=346759&action=review

> Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamerBase.cpp:777
> +        [&](TextureMapperPlatformLayerProxy& proxy)

Do we really need to capture everything? I prefer explicit capture and I guess 'this' is the only thing we need to capture here, no?
Comment 4 Zan Dobersek 2018-08-08 02:30:06 PDT
Created attachment 346761 [details]
Patch for landing
Comment 5 Zan Dobersek 2018-08-08 02:31:10 PDT
Comment on attachment 346761 [details]
Patch for landing

Clearing flags on attachment: 346761

Committed r234688: <https://trac.webkit.org/changeset/234688>
Comment 6 Zan Dobersek 2018-08-08 02:31:14 PDT
All reviewed patches have been landed.  Closing bug.
Comment 7 Radar WebKit Bug Importer 2018-08-08 02:32:24 PDT
<rdar://problem/43039520>
Comment 8 Don Olmstead 2018-08-08 11:36:21 PDT
Created attachment 346779 [details]
WinCairo build fix

An #ifdef guard around USE(NICOSIA) was missing.
Comment 9 Don Olmstead 2018-08-08 12:27:13 PDT
This broke the WinCairo build
Comment 10 Don Olmstead 2018-08-08 12:27:42 PDT
Created attachment 346784 [details]
Build fix
Comment 11 WebKit Commit Bot 2018-08-08 13:54:12 PDT
Comment on attachment 346784 [details]
Build fix

Clearing flags on attachment: 346784

Committed r234710: <https://trac.webkit.org/changeset/234710>
Comment 12 WebKit Commit Bot 2018-08-08 13:54:13 PDT
All reviewed patches have been landed.  Closing bug.