Bug 188401 - [iOS] fast/events/ios/contenteditable-autocapitalize.html is a flaky failure
Summary: [iOS] fast/events/ios/contenteditable-autocapitalize.html is a flaky failure
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Wenson Hsieh
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2018-08-07 19:35 PDT by Wenson Hsieh
Modified: 2018-08-08 08:16 PDT (History)
8 users (show)

See Also:


Attachments
Patch (11.19 KB, patch)
2018-08-07 20:17 PDT, Wenson Hsieh
no flags Details | Formatted Diff | Diff
Update TestExpectation (12.16 KB, patch)
2018-08-07 20:42 PDT, Wenson Hsieh
rniwa: review+
Details | Formatted Diff | Diff
Patch for landing (10.79 KB, patch)
2018-08-08 07:27 PDT, Wenson Hsieh
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Wenson Hsieh 2018-08-07 19:35:42 PDT
<rdar://problem/32542300>
Comment 1 Wenson Hsieh 2018-08-07 20:17:06 PDT
Created attachment 346753 [details]
Patch
Comment 2 Wenson Hsieh 2018-08-07 20:42:29 PDT
Created attachment 346755 [details]
Update TestExpectation
Comment 3 Ryosuke Niwa 2018-08-07 22:22:09 PDT
Comment on attachment 346755 [details]
Update TestExpectation

View in context: https://bugs.webkit.org/attachment.cgi?id=346755&action=review

> Tools/WebKitTestRunner/ios/TestControllerIOS.mm:124
> +
> +    runUntil(m_isDoneWaitingForKeyboardToDismiss, m_currentInvocation->shortTimeout());

Does m_isDoneWaitingForKeyboardToDismiss really need to be a member variable? Can't it just be a static variable local to this file instead?
Alternatively, can simply hand off m_isDoneWaitingForKeyboardToDismiss as an observer
so that we don't have to add willHideKeyboard()/didHideKeyboard() to TestController?
Comment 4 Wenson Hsieh 2018-08-08 07:19:15 PDT
(In reply to Ryosuke Niwa from comment #3)
> Comment on attachment 346755 [details]
> Update TestExpectation
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=346755&action=review
> 
> > Tools/WebKitTestRunner/ios/TestControllerIOS.mm:124
> > +
> > +    runUntil(m_isDoneWaitingForKeyboardToDismiss, m_currentInvocation->shortTimeout());
> 
> Does m_isDoneWaitingForKeyboardToDismiss really need to be a member
> variable? Can't it just be a static variable local to this file instead?
> Alternatively, can simply hand off m_isDoneWaitingForKeyboardToDismiss as an
> observer
> so that we don't have to add willHideKeyboard()/didHideKeyboard() to
> TestController?

Ok — made isDoneWaitingForKeyboardToDismiss a static variable, and removed willHideKeyboard()/didHideKeyboard().
Comment 5 Wenson Hsieh 2018-08-08 07:27:21 PDT
Created attachment 346769 [details]
Patch for landing
Comment 6 WebKit Commit Bot 2018-08-08 08:06:45 PDT
Comment on attachment 346769 [details]
Patch for landing

Clearing flags on attachment: 346769

Committed r234691: <https://trac.webkit.org/changeset/234691>