<rdar://problem/32542300>
Created attachment 346753 [details] Patch
Created attachment 346755 [details] Update TestExpectation
Comment on attachment 346755 [details] Update TestExpectation View in context: https://bugs.webkit.org/attachment.cgi?id=346755&action=review > Tools/WebKitTestRunner/ios/TestControllerIOS.mm:124 > + > + runUntil(m_isDoneWaitingForKeyboardToDismiss, m_currentInvocation->shortTimeout()); Does m_isDoneWaitingForKeyboardToDismiss really need to be a member variable? Can't it just be a static variable local to this file instead? Alternatively, can simply hand off m_isDoneWaitingForKeyboardToDismiss as an observer so that we don't have to add willHideKeyboard()/didHideKeyboard() to TestController?
(In reply to Ryosuke Niwa from comment #3) > Comment on attachment 346755 [details] > Update TestExpectation > > View in context: > https://bugs.webkit.org/attachment.cgi?id=346755&action=review > > > Tools/WebKitTestRunner/ios/TestControllerIOS.mm:124 > > + > > + runUntil(m_isDoneWaitingForKeyboardToDismiss, m_currentInvocation->shortTimeout()); > > Does m_isDoneWaitingForKeyboardToDismiss really need to be a member > variable? Can't it just be a static variable local to this file instead? > Alternatively, can simply hand off m_isDoneWaitingForKeyboardToDismiss as an > observer > so that we don't have to add willHideKeyboard()/didHideKeyboard() to > TestController? Ok — made isDoneWaitingForKeyboardToDismiss a static variable, and removed willHideKeyboard()/didHideKeyboard().
Created attachment 346769 [details] Patch for landing
Comment on attachment 346769 [details] Patch for landing Clearing flags on attachment: 346769 Committed r234691: <https://trac.webkit.org/changeset/234691>