RESOLVED FIXED 18840
[CAIRO] Clipping-support for SVG 
https://bugs.webkit.org/show_bug.cgi?id=18840
Summary [CAIRO] Clipping-support for SVG
Dirk Schulze
Reported 2008-05-02 05:57:19 PDT
There is allready support for Clip in SVG/Cairo, with problems: 1. If you have a clip with more than one path, GraphicsContextCairo makes a intersection instead of a union. http://svg.tutorial.aptico.de/grafik_svg/kap14_1.svg 2. Wrong transformation of skewX and skewY (could be more problems). http://apike.ca/prog_svg_clip.html 2. No animation-support for Clipping
Attachments
Clipping in SVG/Cairo (1.78 KB, patch)
2008-05-02 06:06 PDT, Dirk Schulze 		no flags
DetailsFormatted DiffDiff
Fixed transformation (1.30 KB, patch)
2008-05-04 01:31 PDT, Dirk Schulze 		no flags
DetailsFormatted DiffDiff
Clipping in SVG/Cairo (3.44 KB, patch)
2008-05-17 12:58 PDT, Dirk Schulze 		eric: review-
DetailsFormatted DiffDiff
Clipping in SVG/Cairo (3.52 KB, patch)
2008-06-07 00:09 PDT, Dirk Schulze 		eric: review+
DetailsFormatted DiffDiff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.
Dirk Schulze
Comment 1 2008-05-02 06:06:43 PDT
Created attachment 20922 [details] Clipping in SVG/Cairo The first problem is caused by GraphicsContext. After each insertion of a path, the clip is created and directly drawn to cairo_t. This patch draw the clipping at the end of insertion of paths.
Dirk Schulze
Comment 2 2008-05-04 01:31:25 PDT
Created attachment 20956 [details] Fixed transformation This patch fixes transformation of paths (first point 2).
Dirk Schulze
Comment 3 2008-05-12 10:51:50 PDT
The second point 2 is a problem of animation and localization and affects any animation, not only clipping. If you use e.g. en_US it works, with de_DE or it_IT as language-setting it won't work (export LANG="de_DE.UTF-8").
Dirk Schulze
Comment 4 2008-05-17 12:58:45 PDT
Created attachment 21216 [details] Clipping in SVG/Cairo This patch corrects a bug in the previous patch and combines the fixes on clipping and path-transformation. Furthermore the code keeps with the Cg-implementation for a better code-reading.
Eric Seidel (no email)
Comment 5 2008-06-06 10:11:16 PDT
Comment on attachment 21216 [details] Clipping in SVG/Cairo I'm not sure I understand the matrix changes for path. And why would you want to reset the clip every time you enter applyClip, even if there is no clip to apply? Seems like the early-return when there is no clip could be before the clip-reset.
Dirk Schulze
Comment 6 2008-06-07 00:09:42 PDT
Created attachment 21546 [details] Clipping in SVG/Cairo Made the matrix changes more effective (the inverting is still necessary) and moved cairo_clip_reset() behind the return.
Eric Seidel (no email)
Comment 7 2008-06-07 03:37:35 PDT
Comment on attachment 21546 [details] Clipping in SVG/Cairo Looks fine.
Darin Adler
Comment 8 2008-06-08 13:37:25 PDT
Committed revision 34454.
Note You need to log in before you can comment on or make changes to this bug.