Bug 188395 – ResourceUsageOverlay should use physical footprint for its "Footprint" label

• Status: RESOLVED
• Resolution: FIXED
• Component: JavaScriptCore

[Saam Barati]

...

[Saam Barati]

It uses total dirty pages instead of physical footprint on darwin...

[Saam Barati]

Created attachment 346748 [details]
patch

[Simon Fraser (smfr)]

Comment on attachment 346748 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=346748&action=review

> Source/WebCore/page/cocoa/ResourceUsageOverlayCocoa.mm:461
> +    if (auto footprint = memoryFootprint())

I don't like how memoryFootprint() returns an optional. This isn't normally how we do error handling.

[Saam Barati]

Comment on attachment 346748 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=346748&action=review

>> Source/WebCore/page/cocoa/ResourceUsageOverlayCocoa.mm:461
>> +    if (auto footprint = memoryFootprint())
> 
> I don't like how memoryFootprint() returns an optional. This isn't normally how we do error handling.

Also I don’t even think about this failing as really being standard error handling. A failure here is totally unexpected and not something that happens in practice. We should probably just make that function return zero in such a scenario

[Saam Barati]

I’ll file a bug for this

[WebKit Commit Bot]

Comment on attachment 346748 [details]
patch

Clearing flags on attachment: 346748

Committed r234686: <https://trac.webkit.org/changeset/234686>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Radar WebKit Bug Importer]

<rdar://problem/43033735>