...
It uses total dirty pages instead of physical footprint on darwin...
Created attachment 346748 [details] patch
Comment on attachment 346748 [details] patch View in context: https://bugs.webkit.org/attachment.cgi?id=346748&action=review > Source/WebCore/page/cocoa/ResourceUsageOverlayCocoa.mm:461 > + if (auto footprint = memoryFootprint()) I don't like how memoryFootprint() returns an optional. This isn't normally how we do error handling.
Comment on attachment 346748 [details] patch View in context: https://bugs.webkit.org/attachment.cgi?id=346748&action=review >> Source/WebCore/page/cocoa/ResourceUsageOverlayCocoa.mm:461 >> + if (auto footprint = memoryFootprint()) > > I don't like how memoryFootprint() returns an optional. This isn't normally how we do error handling. Also I don’t even think about this failing as really being standard error handling. A failure here is totally unexpected and not something that happens in practice. We should probably just make that function return zero in such a scenario
I’ll file a bug for this
Comment on attachment 346748 [details] patch Clearing flags on attachment: 346748 Committed r234686: <https://trac.webkit.org/changeset/234686>
All reviewed patches have been landed. Closing bug.
<rdar://problem/43033735>