Bug 188380 - StorageManager should stop ref'ing IPC::Connections as this is leak-prone
Summary: StorageManager should stop ref'ing IPC::Connections as this is leak-prone
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit2 (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Chris Dumez
URL:
Keywords: InRadar
Depends on: 188321
Blocks:
  Show dependency tree / graph
 
Reported: 2018-08-07 10:48 PDT by Chris Dumez
Modified: 2018-08-07 12:10 PDT (History)
4 users (show)

See Also:

Attachments
Patch (26.64 KB, patch)
2018-08-07 10:49 PDT, Chris Dumez 		achristensen: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Dumez 2018-08-07 10:48:04 PDT 
StorageManager should stop ref'ing IPC::Connections as this is leak-prone.
Comment 1 Chris Dumez 2018-08-07 10:49:43 PDT 
Created attachment 346715 [details]
Patch
Comment 2 Alex Christensen 2018-08-07 11:48:50 PDT 
Comment on attachment 346715 [details]
Patch

This feels like a problem that could also be solved with WeakPtr.  Would that make the Connections too big?
Comment 3 Chris Dumez 2018-08-07 11:53:45 PDT 
(In reply to Alex Christensen from comment #2)
> Comment on attachment 346715 [details]
> Patch
> 
> This feels like a problem that could also be solved with WeakPtr.  Would
> that make the Connections too big?

No, but you cannot use WeakPtr as key in a HashMap since its value changes.
Comment 4 Alex Christensen 2018-08-07 12:09:29 PDT 
http://trac.webkit.org/r234664
Comment 5 Radar WebKit Bug Importer 2018-08-07 12:10:20 PDT 
<rdar://problem/43013954>