Bug 188377 - [GTK] [2.20.4] Occasional rendering artifacts
Summary: [GTK] [2.20.4] Occasional rendering artifacts
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKitGTK (show other bugs)
Version: Other
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
: 188471 (view as bug list)
Depends on:
Blocks:
 
Reported: 2018-08-07 03:52 PDT by Alberto Garcia
Modified: 2018-08-13 12:51 PDT (History)
4 users (show)

See Also:


Attachments
Example of corrupted output (28.30 KB, image/png)
2018-08-07 03:52 PDT, Alberto Garcia
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Alberto Garcia 2018-08-07 03:52:50 PDT
Created attachment 346704 [details]
Example of corrupted output

I'm finding occasional rendering artifacts with WebKitGTK+ 2.20.4 that I don't think were present in 2.20.3.

I've seen them in different websites, but here's one simple way to reproduce one:

- Log in to Facebook
- Look for any post and place the mouse pointer over the "Like" button.
- There's a pop up animation with the different kind of reactions ("Love", "Like", "Sad", ...)

The animation should be smooth but in most cases the output is corrupted. See attached screenshot for an example.

I have to say that in most cases the problem disappears after a few seconds and everything looks normal, so this doesn't make the browser unusable.
Comment 1 Miguel Gomez 2018-08-07 04:58:57 PDT
I guess this is due to https://trac.webkit.org/changeset/234420/webkit/releases/WebKitGTK/webkit-2.20 cause it's the only one that seems related.

I think it should get fixed by adding https://trac.webkit.org/changeset/234259/webkit on top of it, but I need to check.
Comment 2 Michael Catanzaro 2018-08-07 05:22:00 PDT
Berto, maybe you could try reverting r234420 and see if that fixes the issue?
Comment 3 Miguel Gomez 2018-08-07 07:12:21 PDT
(In reply to Miguel Gomez from comment #1)
> I guess this is due to
> https://trac.webkit.org/changeset/234420/webkit/releases/WebKitGTK/webkit-2.
> 20 cause it's the only one that seems related.
> 
> I think it should get fixed by adding
> https://trac.webkit.org/changeset/234259/webkit on top of it, but I need to
> check.

Yes, the problem happens because of https://trac.webkit.org/changeset/234420/webkit/releases/WebKitGTK/webkit-2.20, and applying https://trac.webkit.org/changeset/234259/webkit on top of it doesn't fix it, so we better revert it from the stable branch.
Comment 4 Miguel Gomez 2018-08-07 08:10:33 PDT
I've just tested and the problem is not reproducible with ToT. There are some changes on the rendering side that are required for https://trac.webkit.org/changeset/234420/webkit/releases/WebKitGTK/webkit-2.20 and https://trac.webkit.org/changeset/234259/webkit to work properly (specially the removal of UpdateAtlas).

So, reverting on stable is ok and this should not be a problem for the next development release.
Comment 5 Michael Catanzaro 2018-08-07 10:17:17 PDT
Reverted in https://trac.webkit.org/changeset/234656/webkit. Thanks, Berto and Miguel!
Comment 6 Sergio Villar Senin 2018-08-13 12:51:55 PDT
*** Bug 188471 has been marked as a duplicate of this bug. ***