188374 – REGRESSION (r233778): Text selection sometimes cannot be extended in iframes

Bug 188374 - REGRESSION (r233778): Text selection sometimes cannot be extended in iframes

Summary: REGRESSION (r233778): Text selection sometimes cannot be extended in iframes

Status:	RESOLVED FIXED

Alias:	None

Product:	WebKit
Classification:	Unclassified
Component:	HTML Editing (show other bugs)
Version:	WebKit Nightly Build
Hardware:	Unspecified Unspecified

Importance:	P2 Normal
Assignee:	Wenson Hsieh

URL:
Keywords:	InRadar

Duplicates (2):	191081 193663 (view as bug list)
Depends on:
Blocks:

Reported:	2018-08-06 23:02 PDT by Wenson Hsieh
Modified:	2019-01-27 14:23 PST (History)
CC List:	12 users (show)

See Also:

Attachments
Patch (15.20 KB, patch) 2018-08-06 23:24 PDT, Wenson Hsieh	no flags	Details \| Formatted Diff \| Diff
Archive of layout-test-results from ews122 for ios-simulator-wk2 (16.16 MB, application/zip) 2018-08-07 01:24 PDT, EWS Watchlist	no flags	Details
Patch (14.19 KB, patch) 2018-08-07 09:49 PDT, Wenson Hsieh	no flags	Details \| Formatted Diff \| Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Wenson Hsieh 2018-08-06 23:02:42 PDT

<rdar://problem/42928657>

Comment 1 Wenson Hsieh 2018-08-06 23:24:41 PDT

Created attachment 346688 [details]
Patch

Comment 2 EWS Watchlist 2018-08-07 01:24:38 PDT Comment hidden (obsolete)

Comment on attachment 346688 [details]
Patch

Attachment 346688 [details] did not pass ios-sim-ews (ios-simulator-wk2):
Output: https://webkit-queues.webkit.org/results/8785121

New failing tests:
editing/selection/ios/fixed-selection-after-scroll.html
editing/selection/ios/selection-handles-in-iframe.html
editing/selection/ios/absolute-selection-after-scroll.html

Comment 3 EWS Watchlist 2018-08-07 01:24:40 PDT Comment hidden (obsolete)

Created attachment 346693 [details]
Archive of layout-test-results from ews122 for ios-simulator-wk2

The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews122  Port: ios-simulator-wk2  Platform: Mac OS X 10.13.4

Comment 4 Wenson Hsieh 2018-08-07 08:53:59 PDT

Hmmm, UIScriptController.longPressAtPoint doesn't appear to work in iOS 11.4 on trunk, without any internal bits (i.e. OpenSource only). When running MobileSafari against these built products, the long press text selection gesture to select a single word also does not work, so this isn't limited to the test runner.

I might have to keep these tests iOS 12-only for now.

Comment 5 Wenson Hsieh 2018-08-07 09:49:40 PDT

Created attachment 346709 [details]
Patch

Comment 6 WebKit Commit Bot 2018-08-07 11:32:48 PDT

Comment on attachment 346709 [details]
Patch

Clearing flags on attachment: 346709

Committed r234661: <https://trac.webkit.org/changeset/234661>

Comment 7 WebKit Commit Bot 2018-08-07 11:32:50 PDT

All reviewed patches have been landed.  Closing bug.

Comment 8 Wenson Hsieh 2018-10-30 18:10:05 PDT

*** Bug 191081 has been marked as a duplicate of this bug. ***

Comment 9 Wenson Hsieh 2019-01-27 14:23:49 PST

*** Bug 193663 has been marked as a duplicate of this bug. ***