WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
188368
Add CEReactions=NotNeeded on all the relevant IDL files
https://bugs.webkit.org/show_bug.cgi?id=188368
Summary
Add CEReactions=NotNeeded on all the relevant IDL files
Ryosuke Niwa
Reported
2018-08-06 17:14:38 PDT
Now that we have CEReactions=NotNeeded implemented in
https://trac.webkit.org/changeset/234636
, we should mark all relevant IDL attributes, methods, getters, setters, etc... as such.
Attachments
Patch (extracting changes and rebasing attachment 345839)
(60.03 KB, patch)
2018-08-07 01:50 PDT
,
Frédéric Wang (:fredw)
no flags
Details
Formatted Diff
Diff
Archive of layout-test-results from ews202 for win-future
(12.84 MB, application/zip)
2018-08-16 17:11 PDT
,
EWS Watchlist
no flags
Details
Updated for trunk
(63.40 KB, patch)
2018-11-29 20:48 PST
,
Ryosuke Niwa
no flags
Details
Formatted Diff
Diff
Updated for trunk
(63.39 KB, patch)
2018-11-29 20:52 PST
,
Ryosuke Niwa
koivisto
: review+
Details
Formatted Diff
Diff
Show Obsolete
(3)
View All
Add attachment
proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1
2018-08-06 17:15:01 PDT
<
rdar://problem/42987753
>
Frédéric Wang (:fredw)
Comment 2
2018-08-07 01:28:39 PDT
(In reply to Ryosuke Niwa from
comment #0
)
> Now that we have CEReactions=NotNeeded implemented in >
https://trac.webkit.org/changeset/234636
, > we should mark all relevant IDL attributes, methods, getters, setters, > etc... as such.
OK, this is the painful part ;-) For
attachment 345839
[details]
, I checked the idl in the spec one by one and added the extended attributes manually. Maybe we want to do it in a more automated way...
Frédéric Wang (:fredw)
Comment 3
2018-08-07 01:50:32 PDT
Created
attachment 346695
[details]
Patch (extracting changes and rebasing
attachment 345839
[details]
)
Ryosuke Niwa
Comment 4
2018-08-07 22:15:03 PDT
Comment on
attachment 346695
[details]
Patch (extracting changes and rebasing
attachment 345839
[details]
) View in context:
https://bugs.webkit.org/attachment.cgi?id=346695&action=review
> Source/WebCore/html/HTMLElement.idl:65 > [Conditional=IOS_AUTOCORRECT_AND_AUTOCAPITALIZE] attribute boolean autocorrect;
We need CEReactions here too for autocorrect content attribute.
> Source/WebCore/html/HTMLElement.idl:66 > - [Conditional=IOS_AUTOCORRECT_AND_AUTOCAPITALIZE] attribute [TreatNullAs=EmptyString] DOMString autocapitalize; > + [CEReactions, Conditional=IOS_AUTOCORRECT_AND_AUTOCAPITALIZE] attribute [TreatNullAs=EmptyString] DOMString autocapitalize;
We need a test for this. We should probably make this change in a separate patch.
> Source/WebCore/html/HTMLInputElement.idl:91 > [Reflect] attribute boolean incremental;
We should probably add CEReactions=NotNeeded on apparently non-standard IDL attribute.
> Source/WebCore/html/HTMLLinkElement.idl:44 > [Reflect] attribute DOMString nonce;
nonce content attribute should have CEReactions=NotNeeded even though the spec doesn't say that:
https://html.spec.whatwg.org/multipage/urls-and-fetching.html#nonce-attributes
Filed
https://github.com/whatwg/html/issues/3887
> Source/WebCore/html/HTMLMediaElement.idl:96 > attribute boolean webkitPreservesPitch;
Non-standard mediaGroup below should have CEReactions=NotNeeded as well.
> Source/WebCore/html/HTMLPreElement.idl:27 > [Reflect] attribute boolean wrap;
Need CEReactions=NotNeeded on this extension.
> Source/WebCore/html/HTMLScriptElement.idl:31 > [Reflect] attribute DOMString nonce;
We should add CEReactions=NotNeeded here as well.
> Source/WebCore/html/HTMLStyleElement.idl:27 > readonly attribute StyleSheet sheet;
Ditto about adding CEReactions=NotNeeded to the nonce IDL attribute below.
> Source/WebCore/html/HTMLTextAreaElement.idl:39 > + [CEReactions=NotNeeded] attribute [TreatNullAs=EmptyString] DOMString value;
This is probably a spec bug:
https://github.com/whatwg/html/issues/3889
textarea.value never mutates DOM.
EWS Watchlist
Comment 5
2018-08-16 17:11:41 PDT
Comment on
attachment 346695
[details]
Patch (extracting changes and rebasing
attachment 345839
[details]
)
Attachment 346695
[details]
did not pass win-ews (win): Output:
https://webkit-queues.webkit.org/results/8885960
New failing tests: http/tests/security/contentSecurityPolicy/userAgentShadowDOM/allow-video.html
EWS Watchlist
Comment 6
2018-08-16 17:11:53 PDT
Created
attachment 347327
[details]
Archive of layout-test-results from ews202 for win-future The attached test failures were seen while running run-webkit-tests on the win-ews. Bot: ews202 Port: win-future Platform: CYGWIN_NT-6.1-2.10.0-0.325-5-3-x86_64-64bit
Ryosuke Niwa
Comment 7
2018-11-29 20:48:45 PST
Created
attachment 356119
[details]
Updated for trunk
Ryosuke Niwa
Comment 8
2018-11-29 20:52:13 PST
Created
attachment 356121
[details]
Updated for trunk
Frédéric Wang (:fredw)
Comment 9
2018-11-29 21:24:23 PST
I completely forget about this. I can r+ if you need a rubber stamp but maybe someone else should review.
Antti Koivisto
Comment 10
2018-11-30 08:53:29 PST
Comment on
attachment 356121
[details]
Updated for trunk rs=me
Ryosuke Niwa
Comment 11
2018-11-30 11:48:08 PST
Thanks for patch, Frédéric & thanks for the rubber-stamp, Antti!
Ryosuke Niwa
Comment 12
2018-11-30 11:59:35 PST
Committed
r238748
: <
https://trac.webkit.org/changeset/238748
>
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug