Bug 188350 - Use a 1-byte enum class for TextDirection
Summary: Use a 1-byte enum class for TextDirection
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Alex Christensen
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2018-08-06 12:53 PDT by Alex Christensen
Modified: 2018-08-13 11:20 PDT (History)
4 users (show)

See Also:


Attachments
Patch (112.42 KB, patch)
2018-08-06 12:57 PDT, Alex Christensen
no flags Details | Formatted Diff | Diff
Patch (114.74 KB, patch)
2018-08-06 13:11 PDT, Alex Christensen
no flags Details | Formatted Diff | Diff
Patch (115.69 KB, patch)
2018-08-06 13:35 PDT, Alex Christensen
no flags Details | Formatted Diff | Diff
Patch (124.41 KB, patch)
2018-08-06 17:58 PDT, Alex Christensen
no flags Details | Formatted Diff | Diff
Patch (123.83 KB, patch)
2018-08-06 18:37 PDT, Alex Christensen
no flags Details | Formatted Diff | Diff
Patch (125.27 KB, patch)
2018-08-07 10:01 PDT, Alex Christensen
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Alex Christensen 2018-08-06 12:53:40 PDT
Use a 1-byte enum class for TextDirection
Comment 1 Alex Christensen 2018-08-06 12:57:33 PDT
Created attachment 346644 [details]
Patch
Comment 2 EWS Watchlist 2018-08-06 13:01:02 PDT
Attachment 346644 [details] did not pass style-queue:


ERROR: Source/WebCore/platform/text/WritingMode.h:36:  enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums.  [readability/enum_casing] [4]
ERROR: Source/WebCore/platform/UserInterfaceLayoutDirection.h:30:  enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums.  [readability/enum_casing] [4]
ERROR: Source/WebCore/testing/Internals.h:617:  enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums.  [readability/enum_casing] [4]
Total errors found: 3 in 72 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Alex Christensen 2018-08-06 13:11:59 PDT
Created attachment 346645 [details]
Patch
Comment 4 EWS Watchlist 2018-08-06 13:13:40 PDT
Attachment 346645 [details] did not pass style-queue:


ERROR: Source/WebCore/platform/text/WritingMode.h:36:  enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums.  [readability/enum_casing] [4]
ERROR: Source/WebCore/platform/UserInterfaceLayoutDirection.h:30:  enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums.  [readability/enum_casing] [4]
ERROR: Source/WebCore/testing/Internals.h:617:  enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums.  [readability/enum_casing] [4]
Total errors found: 3 in 73 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 5 Alex Christensen 2018-08-06 13:35:31 PDT
Created attachment 346650 [details]
Patch
Comment 6 EWS Watchlist 2018-08-06 13:39:25 PDT
Attachment 346650 [details] did not pass style-queue:


ERROR: Source/WebCore/platform/text/WritingMode.h:36:  enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums.  [readability/enum_casing] [4]
ERROR: Source/WebCore/platform/UserInterfaceLayoutDirection.h:30:  enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums.  [readability/enum_casing] [4]
ERROR: Source/WebCore/testing/Internals.h:617:  enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums.  [readability/enum_casing] [4]
Total errors found: 3 in 74 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 7 Alex Christensen 2018-08-06 17:58:08 PDT
Created attachment 346670 [details]
Patch
Comment 8 EWS Watchlist 2018-08-06 18:00:08 PDT
Attachment 346670 [details] did not pass style-queue:


ERROR: Source/WebCore/platform/text/WritingMode.h:36:  enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums.  [readability/enum_casing] [4]
ERROR: Source/WebCore/platform/UserInterfaceLayoutDirection.h:30:  enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums.  [readability/enum_casing] [4]
ERROR: Source/WebCore/testing/Internals.h:617:  enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums.  [readability/enum_casing] [4]
Total errors found: 3 in 78 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 9 Alex Christensen 2018-08-06 18:37:50 PDT
Created attachment 346675 [details]
Patch
Comment 10 EWS Watchlist 2018-08-06 18:41:10 PDT
Attachment 346675 [details] did not pass style-queue:


ERROR: Source/WebCore/platform/text/WritingMode.h:36:  enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums.  [readability/enum_casing] [4]
ERROR: Source/WebCore/platform/UserInterfaceLayoutDirection.h:30:  enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums.  [readability/enum_casing] [4]
ERROR: Source/WebCore/testing/Internals.h:617:  enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums.  [readability/enum_casing] [4]
Total errors found: 3 in 77 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 11 Alex Christensen 2018-08-07 10:01:17 PDT
Created attachment 346710 [details]
Patch
Comment 12 EWS Watchlist 2018-08-07 10:04:21 PDT
Attachment 346710 [details] did not pass style-queue:


ERROR: Source/WebCore/platform/text/WritingMode.h:36:  enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums.  [readability/enum_casing] [4]
ERROR: Source/WebCore/platform/UserInterfaceLayoutDirection.h:30:  enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums.  [readability/enum_casing] [4]
ERROR: Source/WebCore/testing/Internals.h:617:  enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums.  [readability/enum_casing] [4]
Total errors found: 3 in 78 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 13 WebKit Commit Bot 2018-08-13 11:19:10 PDT
Comment on attachment 346710 [details]
Patch

Clearing flags on attachment: 346710

Committed r234808: <https://trac.webkit.org/changeset/234808>
Comment 14 WebKit Commit Bot 2018-08-13 11:19:12 PDT
All reviewed patches have been landed.  Closing bug.
Comment 15 Radar WebKit Bug Importer 2018-08-13 11:20:31 PDT
<rdar://problem/43242507>