Bug 18835 – spelling underlines disappear when they shouldn't

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Eric Seidel (no email)]

This isn't 100% reproducible, but I can usually get it to happen with the following steps:

1. click into a textarea (add comment field on this page), or editable html region (gmail)
2. type the following: The quick brown foxxx jumped over
3. hit the back arrow four times to move the cursor to the beginning of 'over'
4. hit return

The red squiggle under foxxx will disappear.

I haven't tried on mac, just windows.

[Hironori Bono]

Created attachment 26522 [details]
A Quick Fix

I accidentally noticed a cause of this bug while investigating another issue.
Somehow the InsertLineBreakCommand::doApply() function forgot copying markers while splitting a text node with a line-break key even though there is a CompositeEditCommand::splitTextNode() function, which splits a text node and copy markers.
I'm not sure it is correct to call the CompositeEditCommand::splitTextNode() function here, though.

[Justin Garcia]

Comment on attachment 26522 [details]
A Quick Fix

so, deleteTextFromNode removes spelling markers from text even if the deletion doesn't effect them?  we should document that problem.

do we need to make this change to InsertParagraphSeparatorCommand and BreakBlockquoteCommand?

r=me

[Justin Garcia]

> so, deleteTextFromNode removes spelling markers from text even if the deletion
> doesn't effect them?  we should document that problem.

Oops my mistake, I misread the code, I thought it deleted what was after the caret, not what was before.  Disregard that bit.

[Hironori Bono]

Thank you for your review and comments.

> do we need to make this change to InsertParagraphSeparatorCommand and
> BreakBlockquoteCommand?

As far as I read the InsertParagraphSeparatorCommand::doApply() and BreakBlockquoteCommand::doApply() functions, they already use the splitTextNode() function to split a text node. (This is a reason why my quick fix uses the splitTextNode() function.)

Regards,

Hironori Bono

[Darin Fisher (:fishd, Google)]

http://trac.webkit.org/changeset/40317

[Darin Fisher (:fishd, Google)]

Added missing layout test results:
http://trac.webkit.org/changeset/40341