Bug 188348 - [Nicosia] Add Nicosia::CompositionLayerTextureMapperImpl
Summary: [Nicosia] Add Nicosia::CompositionLayerTextureMapperImpl
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Zan Dobersek
URL:
Keywords: InRadar
Depends on:
Blocks: 187385
  Show dependency tree / graph
 
Reported: 2018-08-06 09:15 PDT by Zan Dobersek
Modified: 2018-08-07 02:09 PDT (History)
3 users (show)

See Also:

Attachments
Patch (9.66 KB, patch)
2018-08-06 09:24 PDT, Zan Dobersek 		no flags Details | Formatted Diff | Diff
Patch for landing (9.71 KB, patch)
2018-08-07 02:07 PDT, Zan Dobersek 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Zan Dobersek 2018-08-06 09:15:10 PDT 
[Nicosia] Add Nicosia::CompositionLayerTextureMapperImpl
Comment 1 Zan Dobersek 2018-08-06 09:24:16 PDT 
Created attachment 346632 [details]
Patch
Comment 2 Carlos Garcia Campos 2018-08-07 00:13:22 PDT 
Comment on attachment 346632 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=346632&action=review

> Source/WebCore/platform/graphics/nicosia/texmap/NicosiaCompositionLayerTextureMapperImpl.h:46
> +    CompositionLayerTextureMapperImpl();

Can we make this private?

> Source/WebCore/platform/graphics/nicosia/texmap/NicosiaCompositionLayerTextureMapperImpl.h:53
> +    CompositionState& compositionState() { return m_compositionState; }

method could be const
Comment 3 Zan Dobersek 2018-08-07 01:43:42 PDT 
Comment on attachment 346632 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=346632&action=review

>> Source/WebCore/platform/graphics/nicosia/texmap/NicosiaCompositionLayerTextureMapperImpl.h:46
>> +    CompositionLayerTextureMapperImpl();
> 
> Can we make this private?

No, because of std::make_unique<>().

>> Source/WebCore/platform/graphics/nicosia/texmap/NicosiaCompositionLayerTextureMapperImpl.h:53
>> +    CompositionState& compositionState() { return m_compositionState; }
> 
> method could be const

Can't be, because the const m_compositionState then can be bound to a non-const reference.
Comment 4 Zan Dobersek 2018-08-07 02:07:59 PDT 
Created attachment 346699 [details]
Patch for landing
Comment 5 Zan Dobersek 2018-08-07 02:08:51 PDT 
Comment on attachment 346699 [details]
Patch for landing

Clearing flags on attachment: 346699

Committed r234644: <https://trac.webkit.org/changeset/234644>
Comment 6 Zan Dobersek 2018-08-07 02:08:55 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 7 Radar WebKit Bug Importer 2018-08-07 02:09:20 PDT 
<rdar://problem/42999762>