Make DOMWindow::scrollBy rely on DOMWindow::scrollTo

[Frédéric Wang (:fredw)]

Follow-up of bug 188300.

[Frédéric Wang (:fredw)]

Created attachment 346620 [details]
Patch

[Darin Adler]

Comment on attachment 346620 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=346620&action=review

> Source/WebCore/page/DOMWindow.cpp:1595
> +    scrollToOptions.left.value() += view->mapFromLayoutToCSSUnits(view->contentsScrollPosition().x());
> +    scrollToOptions.top.value() += view->mapFromLayoutToCSSUnits(view->contentsScrollPosition().y());

I hope there are no rounding differences caused by converting from layout to CSS and back.

[Frédéric Wang (:fredw)]

Comment on attachment 346620 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=346620&action=review

>> Source/WebCore/page/DOMWindow.cpp:1595
>> +    scrollToOptions.top.value() += view->mapFromLayoutToCSSUnits(view->contentsScrollPosition().y());
> 
> I hope there are no rounding differences caused by converting from layout to CSS and back.

Probably there are, but that does not appear on the current set of tests. Not sure how we can avoid that... What do you suggest?

[WebKit Commit Bot]

Comment on attachment 346620 [details]
Patch

Clearing flags on attachment: 346620

Committed r234642: <https://trac.webkit.org/changeset/234642>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Radar WebKit Bug Importer]

<rdar://problem/42998916>