Bug 188340 - [Nicosia] Add Nicosia::Scene
Summary: [Nicosia] Add Nicosia::Scene
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Zan Dobersek
URL:
Keywords: InRadar
Depends on:
Blocks: 187385
  Show dependency tree / graph
 
Reported: 2018-08-06 00:15 PDT by Zan Dobersek
Modified: 2018-08-06 01:47 PDT (History)
3 users (show)

See Also:

Attachments
Patch (13.16 KB, patch)
2018-08-06 00:26 PDT, Zan Dobersek 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Zan Dobersek 2018-08-06 00:15:26 PDT 
[Nicosia] Add Nicosia::Scene
Comment 1 Zan Dobersek 2018-08-06 00:26:05 PDT 
Created attachment 346615 [details]
Patch
Comment 2 Carlos Garcia Campos 2018-08-06 00:41:40 PDT 
Comment on attachment 346615 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=346615&action=review

> Source/WebCore/platform/graphics/nicosia/NicosiaScene.cpp:40
> +Scene::Scene() = default;
> +Scene::~Scene() = default;
> +
> +Scene::State::State() = default;
> +Scene::State::~State() = default;

Do we really need this? Or do you plan to add code to this cpp file in the future?
Comment 3 Zan Dobersek 2018-08-06 01:42:25 PDT 
Comment on attachment 346615 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=346615&action=review

>> Source/WebCore/platform/graphics/nicosia/NicosiaScene.cpp:40
>> +Scene::State::~State() = default;
> 
> Do we really need this? Or do you plan to add code to this cpp file in the future?

It might be necessary to add stuff here. If not, I'll come back and simplify things.
Comment 4 Zan Dobersek 2018-08-06 01:46:32 PDT 
Comment on attachment 346615 [details]
Patch

Clearing flags on attachment: 346615

Committed r234593: <https://trac.webkit.org/changeset/234593>
Comment 5 Zan Dobersek 2018-08-06 01:46:36 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 6 Radar WebKit Bug Importer 2018-08-06 01:47:18 PDT 
<rdar://problem/42961398>