Bug 188325 - Make BlendMode an enum class
Summary: Make BlendMode an enum class
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Alex Christensen
URL:
Keywords: InRadar
: 188147 (view as bug list)
Depends on:
Blocks:
 
Reported: 2018-08-03 18:08 PDT by Alex Christensen
Modified: 2018-08-06 16:10 PDT (History)
4 users (show)

See Also:

Attachments
Patch (55.02 KB, patch)
2018-08-03 18:10 PDT, Alex Christensen 		no flags Details | Formatted Diff | Diff
Patch (74.37 KB, patch)
2018-08-03 18:34 PDT, Alex Christensen 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Alex Christensen 2018-08-03 18:08:13 PDT 
Make BlendMode an enum class
Comment 1 Alex Christensen 2018-08-03 18:10:09 PDT 
Created attachment 346571 [details]
Patch
Comment 2 Alex Christensen 2018-08-03 18:34:37 PDT 
Created attachment 346574 [details]
Patch
Comment 3 Simon Fraser (smfr) 2018-08-03 20:34:33 PDT 
I did this in bug 188147 but it broke SVG animation tests. How does yours not?
Comment 4 Alex Christensen 2018-08-06 10:51:52 PDT 
Comment on attachment 346574 [details]
Patch

¯\_(ツ)_/¯
Comment 5 WebKit Commit Bot 2018-08-06 11:19:51 PDT 
Comment on attachment 346574 [details]
Patch

Clearing flags on attachment: 346574

Committed r234610: <https://trac.webkit.org/changeset/234610>
Comment 6 WebKit Commit Bot 2018-08-06 11:19:52 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 7 Alex Christensen 2018-08-06 11:31:09 PDT 
*** Bug 188147 has been marked as a duplicate of this bug. ***
Comment 8 Radar WebKit Bug Importer 2018-08-06 16:10:40 PDT 
<rdar://problem/42985608>