Bug 188324 – Give the `jsc` shell the JIT entitlement

• Status: RESOLVED
• Resolution: FIXED
• Component: JavaScriptCore

[Saam Barati]

...

[Saam Barati]

<rdar://problem/42885806>

[Saam Barati]

Created attachment 346570 [details]
patch

[EWS Watchlist]

Comment on attachment 346570 [details]
patch

Attachment 346570 [details] did not pass win-ews (win):
Output: https://webkit-queues.webkit.org/results/8758024

New failing tests:
http/tests/security/canvas-remote-read-remote-video-blocked-no-crossorigin.html

[EWS Watchlist]

Created attachment 346579 [details]
Archive of layout-test-results from ews206 for win-future

The attached test failures were seen while running run-webkit-tests on the win-ews.
Bot: ews206  Port: win-future  Platform: CYGWIN_NT-6.1-2.9.0-0.318-5-3-x86_64-64bit

[Saam Barati]

I've verified installing a root with this change allows system `jsc` to JIT on macOS Mojave

[Saam Barati]

(In reply to Build Bot from comment #3)
> Comment on attachment 346570 [details]
> patch
> 
> Attachment 346570 [details] did not pass win-ews (win):
> Output: https://webkit-queues.webkit.org/results/8758024
> 
> New failing tests:
> http/tests/security/canvas-remote-read-remote-video-blocked-no-crossorigin.
> html

This is not from this patch. This patch doesn't touch anything in windows.

[WebKit Commit Bot]

Comment on attachment 346570 [details]
patch

Clearing flags on attachment: 346570

Committed r234576: <https://trac.webkit.org/changeset/234576>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Alexey Proskuryakov]

Comment on attachment 346570 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=346570&action=review

> Source/JavaScriptCore/Configurations/JSC.xcconfig:35
>  CODE_SIGN_ENTITLEMENTS[sdk=iphone*] = entitlements.plist;
> +CODE_SIGN_ENTITLEMENTS[sdk=macosx*] = allow-jit-macOS.entitlements;

The file naming seems inconsistent, why is one .plist, and another .entitlements?

Comment on attachment 346570 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=346570&action=review

>> Source/JavaScriptCore/Configurations/JSC.xcconfig:35
>> +CODE_SIGN_ENTITLEMENTS[sdk=macosx*] = allow-jit-macOS.entitlements;
> 
> The file naming seems inconsistent, why is one .plist, and another .entitlements?

One was named before the .entitlements extension was established and gained support in Xcode. The other was named after.

[Saam Barati]

Filed:
https://bugs.webkit.org/show_bug.cgi?id=188332