Bug 188324 - Give the `jsc` shell the JIT entitlement
Summary: Give the `jsc` shell the JIT entitlement
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Saam Barati
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2018-08-03 17:43 PDT by Saam Barati
Modified: 2018-08-04 16:07 PDT (History)
10 users (show)

See Also:

Attachments
patch (4.19 KB, patch)
2018-08-03 17:54 PDT, Saam Barati 		no flags Details | Formatted Diff | Diff
Archive of layout-test-results from ews206 for win-future (13.05 MB, application/zip)
2018-08-03 20:30 PDT, EWS Watchlist 		no flags Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Saam Barati 2018-08-03 17:43:28 PDT 
...
Comment 1 Saam Barati 2018-08-03 17:43:56 PDT 
<rdar://problem/42885806>
Comment 2 Saam Barati 2018-08-03 17:54:24 PDT 
Created attachment 346570 [details]
patch
Comment 3 EWS Watchlist 2018-08-03 20:30:47 PDT 
Comment on attachment 346570 [details]
patch

Attachment 346570 [details] did not pass win-ews (win):
Output: https://webkit-queues.webkit.org/results/8758024

New failing tests:
http/tests/security/canvas-remote-read-remote-video-blocked-no-crossorigin.html
Comment 4 EWS Watchlist 2018-08-03 20:30:59 PDT 
Created attachment 346579 [details]
Archive of layout-test-results from ews206 for win-future

The attached test failures were seen while running run-webkit-tests on the win-ews.
Bot: ews206  Port: win-future  Platform: CYGWIN_NT-6.1-2.9.0-0.318-5-3-x86_64-64bit
Comment 5 Saam Barati 2018-08-03 23:00:40 PDT 
I've verified installing a root with this change allows system `jsc` to JIT on macOS Mojave
Comment 6 Saam Barati 2018-08-03 23:01:02 PDT 
(In reply to Build Bot from comment #3)
> Comment on attachment 346570 [details]
> patch
> 
> Attachment 346570 [details] did not pass win-ews (win):
> Output: https://webkit-queues.webkit.org/results/8758024
> 
> New failing tests:
> http/tests/security/canvas-remote-read-remote-video-blocked-no-crossorigin.
> html

This is not from this patch. This patch doesn't touch anything in windows.
Comment 7 WebKit Commit Bot 2018-08-03 23:27:30 PDT 
Comment on attachment 346570 [details]
patch

Clearing flags on attachment: 346570

Committed r234576: <https://trac.webkit.org/changeset/234576>
Comment 8 WebKit Commit Bot 2018-08-03 23:27:32 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 9 Alexey Proskuryakov 2018-08-04 12:53:52 PDT 
Comment on attachment 346570 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=346570&action=review

> Source/JavaScriptCore/Configurations/JSC.xcconfig:35
>  CODE_SIGN_ENTITLEMENTS[sdk=iphone*] = entitlements.plist;
> +CODE_SIGN_ENTITLEMENTS[sdk=macosx*] = allow-jit-macOS.entitlements;

The file naming seems inconsistent, why is one .plist, and another .entitlements?
Comment 10 mitz 2018-08-04 12:55:31 PDT 
Comment on attachment 346570 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=346570&action=review

>> Source/JavaScriptCore/Configurations/JSC.xcconfig:35
>> +CODE_SIGN_ENTITLEMENTS[sdk=macosx*] = allow-jit-macOS.entitlements;
> 
> The file naming seems inconsistent, why is one .plist, and another .entitlements?

One was named before the .entitlements extension was established and gained support in Xcode. The other was named after.
Comment 11 Saam Barati 2018-08-04 16:07:31 PDT 
Filed:
https://bugs.webkit.org/show_bug.cgi?id=188332