Bug 188323 - Use enum classes and OptionSets for PaintPhase and PaintBehavior
Summary: Use enum classes and OptionSets for PaintPhase and PaintBehavior
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Alex Christensen
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2018-08-03 17:30 PDT by Alex Christensen
Modified: 2018-08-06 16:38 PDT (History)
5 users (show)

See Also:

Attachments
Patch (151.52 KB, patch)
2018-08-03 17:34 PDT, Alex Christensen 		no flags Details | Formatted Diff | Diff
Patch (151.58 KB, patch)
2018-08-03 18:26 PDT, Alex Christensen 		no flags Details | Formatted Diff | Diff
Archive of layout-test-results from ews116 for mac-sierra (1.29 MB, application/zip)
2018-08-03 19:18 PDT, EWS Watchlist 		no flags Details
Patch (153.52 KB, patch)
2018-08-06 11:33 PDT, Alex Christensen 		no flags Details | Formatted Diff | Diff
Patch (155.41 KB, patch)
2018-08-06 12:34 PDT, Alex Christensen 		commit-queue: commit-queue-
Details | Formatted Diff | Diff
Show Obsolete (4) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Alex Christensen 2018-08-03 17:30:40 PDT 
Use enum classes and OptionSets for PaintPhase and PaintBehavior
Comment 1 Alex Christensen 2018-08-03 17:34:04 PDT 
Created attachment 346568 [details]
Patch
Comment 2 Alex Christensen 2018-08-03 18:26:32 PDT 
Created attachment 346573 [details]
Patch
Comment 3 EWS Watchlist 2018-08-03 19:18:43 PDT 
Comment on attachment 346573 [details]
Patch

Attachment 346573 [details] did not pass mac-debug-ews (mac):
Output: https://webkit-queues.webkit.org/results/8757691

Number of test failures exceeded the failure limit.
Comment 4 EWS Watchlist 2018-08-03 19:18:44 PDT 
Created attachment 346576 [details]
Archive of layout-test-results from ews116 for mac-sierra

The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews116  Port: mac-sierra  Platform: Mac OS X 10.12.6
Comment 5 Simon Fraser (smfr) 2018-08-03 20:41:32 PDT 
Comment on attachment 346573 [details]
Patch

Make sure it builds!
Comment 6 Alex Christensen 2018-08-06 11:33:06 PDT 
Created attachment 346637 [details]
Patch
Comment 7 Alex Christensen 2018-08-06 12:34:53 PDT 
Created attachment 346641 [details]
Patch
Comment 8 WebKit Commit Bot 2018-08-06 12:39:04 PDT 
Comment on attachment 346641 [details]
Patch

Rejecting attachment 346641 [details] from commit-queue.

Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-02', 'validate-changelog', '--check-oops', '--non-interactive', 346641, '--port=mac']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit

Simon Frasier found in /Volumes/Data/EWS/WebKit/Source/WTF/ChangeLog does not appear to be a valid reviewer according to contributors.json.
/Volumes/Data/EWS/WebKit/Source/WTF/ChangeLog neither lists a valid reviewer nor contains the string "Unreviewed" or "Rubber stamp" (case insensitive).

Full output: https://webkit-queues.webkit.org/results/8778620
Comment 9 Alex Christensen 2018-08-06 13:41:20 PDT 
http://trac.webkit.org/r234619
Comment 10 Radar WebKit Bug Importer 2018-08-06 16:38:22 PDT 
<rdar://problem/42986547>