Bug 188314 – Add LogArgument template for PlatformMediaSession::RemoteControlCommandType

• Status: RESOLVED
• Resolution: FIXED
• Component: Media

[Eric Carlson]

Log PlatformMediaSession::RemoteControlCommandType as a readable string.

[Radar WebKit Bug Importer]

<rdar://problem/42906364>

[Eric Carlson]

Created attachment 346505 [details]
Patch

[Alex Christensen]

Comment on attachment 346505 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=346505&action=review

> Source/WebCore/platform/audio/PlatformMediaSession.cpp:102
> +    static_assert(static_cast<size_t>(PlatformMediaSession::PlayCommand == 1), "PlatformMediaSession::PlayCommand is not 1 as expected");

Why do you need to convert the booleans into size_t's?

> Source/WebCore/platform/audio/PlatformMediaSession.cpp:112
> +    ASSERT(static_cast<size_t>(command) < WTF_ARRAY_LENGTH(values));
> +    return values[static_cast<size_t>(command)];

I think a switch statement would be more appropriate here.  It would allow the compiler to give you an error if you're missing a case if you don't have a default.

[Eric Carlson]

Comment on attachment 346505 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=346505&action=review

>> Source/WebCore/platform/audio/PlatformMediaSession.cpp:102
>> +    static_assert(static_cast<size_t>(PlatformMediaSession::PlayCommand == 1), "PlatformMediaSession::PlayCommand is not 1 as expected");
> 
> Why do you need to convert the booleans into size_t's?

It doesn't convert boolean to size_t, it converts an enum to a size_t so it can be compared to an integer. 

I just copied the style of the convertEnumerationToString() generated for all enums in IDL.

>> Source/WebCore/platform/audio/PlatformMediaSession.cpp:112
>> +    return values[static_cast<size_t>(command)];
> 
> I think a switch statement would be more appropriate here.  It would allow the compiler to give you an error if you're missing a case if you don't have a default.

Is there a plan to do that for the 250 enums defined in IDL?

[Alex Christensen]

Comment on attachment 346505 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=346505&action=review

>>> Source/WebCore/platform/audio/PlatformMediaSession.cpp:102
>>> +    static_assert(static_cast<size_t>(PlatformMediaSession::PlayCommand == 1), "PlatformMediaSession::PlayCommand is not 1 as expected");
>> 
>> Why do you need to convert the booleans into size_t's?
> 
> It doesn't convert boolean to size_t, it converts an enum to a size_t so it can be compared to an integer. 
> 
> I just copied the style of the convertEnumerationToString() generated for all enums in IDL.

I see that now, but you put the parentheses in the wrong place.

[Eric Carlson]

Created attachment 346774 [details]
Patch for landing

[WebKit Commit Bot]

Comment on attachment 346774 [details]
Patch for landing

Clearing flags on attachment: 346774

Committed r234703: <https://trac.webkit.org/changeset/234703>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.