Bug 188297 - [LFC] Do not check margin box while validating geometry.
Summary: [LFC] Do not check margin box while validating geometry.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: zalan
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2018-08-02 21:38 PDT by zalan
Modified: 2018-08-03 07:22 PDT (History)
5 users (show)

See Also:

Attachments
Patch (1.71 KB, patch)
2018-08-02 21:42 PDT, zalan 		no flags Details | Formatted Diff | Diff
Patch (1.87 KB, patch)
2018-08-03 06:42 PDT, zalan 		koivisto: review+
Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description zalan 2018-08-02 21:38:59 PDT 
the current RenderBox::marginBox is not spec compliant.
Comment 1 zalan 2018-08-02 21:42:16 PDT 
Created attachment 346452 [details]
Patch
Comment 2 zalan 2018-08-02 21:43:53 PDT 
Comment on attachment 346452 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=346452&action=review

> Source/WebCore/layout/Verification.cpp:137
> +#if 0

Not sure what WebKit's policy is about keeping such code around. This will be re-enabled at some point (probably by adding a new function to RenderBox)
Comment 3 zalan 2018-08-03 06:42:43 PDT 
Created attachment 346477 [details]
Patch
Comment 4 zalan 2018-08-03 07:21:27 PDT 
Committed r234544: <https://trac.webkit.org/changeset/234544>
Comment 5 Radar WebKit Bug Importer 2018-08-03 07:22:20 PDT 
<rdar://problem/42898938>