Bug 188293 - [Curl] Test gardening
Summary: [Curl] Test gardening
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Basuke Suzuki
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2018-08-02 17:40 PDT by Basuke Suzuki
Modified: 2018-08-02 22:25 PDT (History)
3 users (show)

See Also:

Attachments
PATCH (13.26 KB, patch)
2018-08-02 17:44 PDT, Basuke Suzuki 		commit-queue: commit-queue-
Details | Formatted Diff | Diff
PATCH (13.26 KB, patch)
2018-08-02 21:45 PDT, Basuke Suzuki 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Basuke Suzuki 2018-08-02 17:40:28 PDT 
Unskip some http tests.
Comment 1 Basuke Suzuki 2018-08-02 17:44:48 PDT 
Created attachment 346438 [details]
PATCH
Comment 2 WebKit Commit Bot 2018-08-02 17:46:43 PDT 
Comment on attachment 346438 [details]
PATCH

Rejecting attachment 346438 [details] from commit-queue.

Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-02', 'validate-changelog', '--check-oops', '--non-interactive', 346438, '--port=mac']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit

test gardening found in /Volumes/Data/EWS/WebKit/LayoutTests/ChangeLog does not appear to be a valid reviewer according to contributors.json.
/Volumes/Data/EWS/WebKit/LayoutTests/ChangeLog neither lists a valid reviewer nor contains the string "Unreviewed" or "Rubber stamp" (case insensitive).

Full output: https://webkit-queues.webkit.org/results/8744046
Comment 3 Basuke Suzuki 2018-08-02 21:45:09 PDT 
Created attachment 346453 [details]
PATCH
Comment 4 WebKit Commit Bot 2018-08-02 22:24:14 PDT 
Comment on attachment 346453 [details]
PATCH

Clearing flags on attachment: 346453

Committed r234538: <https://trac.webkit.org/changeset/234538>
Comment 5 WebKit Commit Bot 2018-08-02 22:24:16 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 6 Radar WebKit Bug Importer 2018-08-02 22:25:16 PDT 
<rdar://problem/42887819>