Bug 188277 - Move queue processing logic from CustomElementReactionStack to CustomElementReactionQueue
Summary: Move queue processing logic from CustomElementReactionStack to CustomElementR...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: DOM (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Ryosuke Niwa
URL:
Keywords: InRadar
Depends on:
Blocks: 187805
  Show dependency tree / graph
 
Reported: 2018-08-02 14:19 PDT by Ryosuke Niwa
Modified: 2018-08-02 15:38 PDT (History)
8 users (show)

See Also:

Attachments
Cleanup (8.70 KB, patch)
2018-08-02 14:22 PDT, Ryosuke Niwa 		wenson_hsieh: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Ryosuke Niwa 2018-08-02 14:19:51 PDT 
CustomElementReactionStack is supposed to be a simple class which simply invokes the logic in CustomElementReactionQueue.
Move more code from CustomElementReactionStack to CustomElementReactionQueue to that end.
Comment 1 Ryosuke Niwa 2018-08-02 14:22:28 PDT 
Created attachment 346417 [details]
Cleanup
Comment 2 Wenson Hsieh 2018-08-02 14:37:57 PDT 
Comment on attachment 346417 [details]
Cleanup

View in context: https://bugs.webkit.org/attachment.cgi?id=346417&action=review

rs=me

> Source/WebCore/dom/CustomElementReactionQueue.h:97
> +    CustomElementReactionQueue::ElementQueue* m_queue { nullptr }; // Use raw pointer to avoid generarting delete in the destructor.

generarting!
Comment 3 Ryosuke Niwa 2018-08-02 15:37:11 PDT 
Committed r234520: <https://trac.webkit.org/changeset/234520>
Comment 4 Radar WebKit Bug Importer 2018-08-02 15:38:36 PDT 
<rdar://problem/42876536>