WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
188277
Move queue processing logic from CustomElementReactionStack to CustomElementReactionQueue
https://bugs.webkit.org/show_bug.cgi?id=188277
Summary
Move queue processing logic from CustomElementReactionStack to CustomElementR...
Ryosuke Niwa
Reported
2018-08-02 14:19:51 PDT
CustomElementReactionStack is supposed to be a simple class which simply invokes the logic in CustomElementReactionQueue. Move more code from CustomElementReactionStack to CustomElementReactionQueue to that end.
Attachments
Cleanup
(8.70 KB, patch)
2018-08-02 14:22 PDT
,
Ryosuke Niwa
wenson_hsieh
: review+
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Ryosuke Niwa
Comment 1
2018-08-02 14:22:28 PDT
Created
attachment 346417
[details]
Cleanup
Wenson Hsieh
Comment 2
2018-08-02 14:37:57 PDT
Comment on
attachment 346417
[details]
Cleanup View in context:
https://bugs.webkit.org/attachment.cgi?id=346417&action=review
rs=me
> Source/WebCore/dom/CustomElementReactionQueue.h:97 > + CustomElementReactionQueue::ElementQueue* m_queue { nullptr }; // Use raw pointer to avoid generarting delete in the destructor.
generarting!
Ryosuke Niwa
Comment 3
2018-08-02 15:37:11 PDT
Committed
r234520
: <
https://trac.webkit.org/changeset/234520
>
Radar WebKit Bug Importer
Comment 4
2018-08-02 15:38:36 PDT
<
rdar://problem/42876536
>
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug