Bug 188260 - Text selection color is hard to see in dark mode web views
Summary: Text selection color is hard to see in dark mode web views
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Timothy Hatcher
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2018-08-02 10:05 PDT by Timothy Hatcher
Modified: 2018-08-02 13:12 PDT (History)
8 users (show)

See Also:

Attachments
Patch (10.85 KB, patch)
2018-08-02 10:16 PDT, Timothy Hatcher 		no flags Details | Formatted Diff | Diff
Before: blendWithWhite() (156.32 KB, image/png)
2018-08-02 10:17 PDT, Timothy Hatcher 		no flags Details
After: 80% Alpha (154.85 KB, image/png)
2018-08-02 10:17 PDT, Timothy Hatcher 		no flags Details
Patch (11.02 KB, patch)
2018-08-02 12:34 PDT, Timothy Hatcher 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Timothy Hatcher 2018-08-02 10:05:57 PDT 
rdar://problem/42721294
Comment 1 Timothy Hatcher 2018-08-02 10:16:41 PDT Comment hidden (obsolete)
Comment 2 Timothy Hatcher 2018-08-02 10:17:08 PDT 
Created attachment 346390 [details]
Before: blendWithWhite()
Comment 3 Timothy Hatcher 2018-08-02 10:17:21 PDT 
Created attachment 346391 [details]
After: 80% Alpha
Comment 4 Simon Fraser (smfr) 2018-08-02 10:56:28 PDT 
Comment on attachment 346389 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=346389&action=review

> Source/WebCore/rendering/RenderThemeMac.mm:345
> +        return !color.isOpaque() ? color : color.colorWithAlpha(0.8);

Would be nicer to say where the 0.8 comes from.

> Source/WebCore/rendering/RenderThemeMac.mm:784
> +                return Color(0xCC3F638B, Color::Semantic);

Would prefer to see use the Color(int, int, int) constructor.
Comment 5 Timothy Hatcher 2018-08-02 12:26:55 PDT 
Comment on attachment 346389 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=346389&action=review

>> Source/WebCore/rendering/RenderThemeMac.mm:345
>> +        return !color.isOpaque() ? color : color.colorWithAlpha(0.8);
> 
> Would be nicer to say where the 0.8 comes from.

Okay.

>> Source/WebCore/rendering/RenderThemeMac.mm:784
>> +                return Color(0xCC3F638B, Color::Semantic);
> 
> Would prefer to see use the Color(int, int, int) constructor.

Other colors in RenderTheme are hex, so I kept them consistent.
Comment 6 Timothy Hatcher 2018-08-02 12:34:25 PDT 
Created attachment 346406 [details]
Patch
Comment 7 WebKit Commit Bot 2018-08-02 13:12:48 PDT 
Comment on attachment 346406 [details]
Patch

Clearing flags on attachment: 346406

Committed r234512: <https://trac.webkit.org/changeset/234512>
Comment 8 WebKit Commit Bot 2018-08-02 13:12:49 PDT 
All reviewed patches have been landed.  Closing bug.