Bug 188255 - [Win][DLLLauncher] Remove --highDPI switch
Summary: [Win][DLLLauncher] Remove --highDPI switch
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Fujii Hironori
Keywords: InRadar
Depends on:
Reported: 2018-08-02 03:54 PDT by Fujii Hironori
Modified: 2018-08-06 16:33 PDT (History)
9 users (show)

See Also:

Patch (2.96 KB, patch)
2018-08-06 02:04 PDT, Fujii Hironori
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Fujii Hironori 2018-08-02 03:54:36 PDT
[WinCairo] All dump render tree tests are failing in high DPI

shouldUseHighDPI should return false for DumpRenderTree.
Comment 1 Fujii Hironori 2018-08-02 04:00:09 PDT
I uploaded the result of fast/css/001.htm.
RenderView sizes are different.
Comment 2 Fujii Hironori 2018-08-06 01:24:14 PDT
This code has been added in Bug 149417.
But, Bug 158733 has made MiniBrowser always DPI aware. It became useless since the change.

Bug 149417 – [Win] Use command-line argument to launch in regular or High DPI mode
Bug 158733 – [Win] MiniBrowser is not DPI aware.
Comment 3 Fujii Hironori 2018-08-06 02:04:02 PDT
Created attachment 346618 [details]
Comment 4 Yusuke Suzuki 2018-08-06 03:00:34 PDT
Comment on attachment 346618 [details]

Comment 5 WebKit Commit Bot 2018-08-06 10:43:50 PDT
Comment on attachment 346618 [details]

Clearing flags on attachment: 346618

Committed r234607: <https://trac.webkit.org/changeset/234607>
Comment 6 WebKit Commit Bot 2018-08-06 10:43:51 PDT
All reviewed patches have been landed.  Closing bug.
Comment 7 Radar WebKit Bug Importer 2018-08-06 10:44:17 PDT