Bug 188251 – [iOS] Keyboard becomes unresponsive after pressing delete while pressing down on a character key with accents

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKit2

[Wenson Hsieh]

<rdar://problem/37842108>

[Wenson Hsieh]

This following code:

- (void)handleKeyWebEvent:(::WebEvent *)theEvent withCompletionHandler:(void (^)(::WebEvent *theEvent, BOOL wasHandled))completionHandler
{
    _keyWebEventHandler = [completionHandler copy];
    _page->handleKeyboardEvent(NativeWebKeyboardEvent(theEvent));
}

- (void)_didHandleKeyEvent:(::WebEvent *)event eventWasHandled:(BOOL)eventWasHandled
{
    if (_keyWebEventHandler) {
        _keyWebEventHandler(event, eventWasHandled);
        [_keyWebEventHandler release];
        _keyWebEventHandler = nil;
        return;
    }

…

}

...is not robust in the case where the key event completion handler calls back into -handleKeyWebEvent:withCompletionHandler:, since we'll just end up stomping over the newly stored completion block in the next line.

[Wenson Hsieh]

Created attachment 346360 [details]
Patch

[Wenson Hsieh]

Created attachment 346380 [details]
Patch

[Wenson Hsieh]

Comment on attachment 346380 [details]
Patch

Thanks for the review!

[WebKit Commit Bot]

Comment on attachment 346380 [details]
Patch

Clearing flags on attachment: 346380

Committed r234504: <https://trac.webkit.org/changeset/234504>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.