RESOLVED FIXED 188249
[LFC][Floating] Convert all coordinates relative to the formatting context root. 
https://bugs.webkit.org/show_bug.cgi?id=188249
Summary [LFC][Floating] Convert all coordinates relative to the formatting context root.
zalan
Reported 2018-08-01 21:38:33 PDT
to ease up on the computation logic.
Attachments
Patch (28.00 KB, patch)
2018-08-01 21:46 PDT, zalan 		koivisto: review+
ews-watchlist: commit-queue-
DetailsFormatted DiffDiff
Archive of layout-test-results from ews205 for win-future (13.03 MB, application/zip)
2018-08-02 01:43 PDT, EWS Watchlist 		no flags
Details
View All Add attachment proposed patch, testcase, etc.
zalan
Comment 1 2018-08-01 21:46:36 PDT
Created attachment 346357 [details] Patch
EWS Watchlist
Comment 2 2018-08-02 01:43:10 PDT
Comment on attachment 346357 [details] Patch Attachment 346357 [details] did not pass win-ews (win): Output: https://webkit-queues.webkit.org/results/8735317 New failing tests: imported/blink/transitions/unprefixed-transform.html legacy-animation-engine/imported/blink/transitions/unprefixed-transform.html
EWS Watchlist
Comment 3 2018-08-02 01:43:21 PDT
Created attachment 346365 [details] Archive of layout-test-results from ews205 for win-future The attached test failures were seen while running run-webkit-tests on the win-ews. Bot: ews205 Port: win-future Platform: CYGWIN_NT-6.1-2.9.0-0.318-5-3-x86_64-64bit
Antti Koivisto
Comment 4 2018-08-02 07:24:59 PDT
Comment on attachment 346357 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=346357&action=review > Source/WebCore/ChangeLog:8 > + The idea here is that all the float related computation should be happening in the same coordinate sytem. spelling "system"
zalan
Comment 5 2018-08-02 07:28:35 PDT
Committed r234499: <https://trac.webkit.org/changeset/234499>
Radar WebKit Bug Importer
Comment 6 2018-08-02 07:30:18 PDT
<rdar://problem/42855390>
Note You need to log in before you can comment on or make changes to this bug.