Bug 188240 – WebContent crashes on initialization with a local WebKit build on macOS Mojave seed

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKit Misc.

[Devin Rousso]

Created attachment 346303 [details]
[Log] Crash

Possibly related to <https://webkit.org/b/188238>, but I can't say for sure.

[Joseph Pecoraro]

Hmm, this code just does a dispatch_sync to the main queue after checking ![NSThread isMainThread]. Whats up wit that?

> Exception Type:        EXC_BAD_INSTRUCTION (SIGILL)
> Exception Codes:       0x0000000000000001, 0x0000000000000000
> Exception Note:        EXC_CORPSE_NOTIFY
> 
> Application Specific Information:
> BUG IN CLIENT OF LIBDISPATCH: dispatch_sync called on queue already owned by current thread
> 
> Thread 1 Crashed:: Dispatch queue: com.apple.main-thread
> 0   libdispatch.dylib             	0x00007fff7e0bda2e __DISPATCH_WAIT_FOR_QUEUE__ + 392
> 1   libdispatch.dylib             	0x00007fff7e0bd611 _dispatch_sync_f_slow + 171
> 2   com.apple.WebKit              	0x000000010eab2e60 WebKit::InitializeWebKit2()::$_0::operator()() const + 80 (WebKit2InitializeCocoa.mm:68)
> 3   com.apple.WebKit              	0x000000010eab2dfb void std::__1::__call_once_proxy<std::__1::tuple<WebKit::InitializeWebKit2()::$_0&&> >(void*) + 91 (mutex:650)
> 4   libc++.1.dylib                	0x00007fff7b8e1c8a std::__1::__call_once(unsigned long volatile&, void*, void (*)(void*)) + 139
> 5   com.apple.WebKit              	0x000000010eab2d91 WebKit::InitializeWebKit2() + 289 (WebKit2InitializeCocoa.mm:69)
> ...

[Alexey Proskuryakov]

It appears to be quite confused about which thread is main.

[Radar WebKit Bug Importer]

<rdar://problem/42936173>

[Chris Dumez]

Seems related:
http://blog.benjamin-encz.de/post/main-queue-vs-main-thread/

[Chris Dumez]

Maybe we can use:
https://developer.apple.com/documentation/objectivec/nsobject/1414900-performselectoronmainthread

With waitUntilDone:YES.

[Chris Dumez]

Devin, could you please clarify if this happens consistently on startup or this was a one time thing?

Many people (including me) are running local builds of WebKit on recent builds of Mojave, without issue.

[Devin Rousso]

(In reply to Chris Dumez from comment #6)
> Devin, could you please clarify if this happens consistently on startup or
> this was a one time thing?
I had multiple crash reports from the exact same time that all had the same error.  I only uploaded one since they were all the same.  When the page crashed, it would attempt to reload, only to crash again, and then repeat the cycle.

[Chris Dumez]

Please update to the latest macOS 12.14 beta, this should have been fixed already.

[Chris Dumez]

(In reply to Chris Dumez from comment #8)
> Please update to the latest macOS 12.14 beta, this should have been fixed
> already.

You're using the 4th developer seed and the latest one if the 6th. The 6th should definitely have the fix.