RESOLVED FIXED 188232
[LFC][Floating] Revert back to only one list for the all the floatings. 
https://bugs.webkit.org/show_bug.cgi?id=188232
Summary [LFC][Floating] Revert back to only one list for the all the floatings.
zalan
Reported 2018-08-01 12:35:02 PDT
to simplify implementation. if it ends up being a perf bottleneck, we can still split it into left and right floatings.
Attachments
Patch (13.52 KB, patch)
2018-08-01 12:41 PDT, zalan 		no flags
DetailsFormatted DiffDiff
Patch (13.57 KB, patch)
2018-08-01 13:30 PDT, zalan 		koivisto: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
zalan
Comment 1 2018-08-01 12:41:15 PDT
Created attachment 346289 [details] Patch
zalan
Comment 2 2018-08-01 13:30:23 PDT
Created attachment 346293 [details] Patch
Antti Koivisto
Comment 3 2018-08-01 13:55:08 PDT
Comment on attachment 346293 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=346293&action=review > Source/WebCore/layout/FloatingState.h:64 > + FloatingList m_floatings; Is "floatings" a spec term or something? To me "floats" sounds better.
zalan
Comment 4 2018-08-01 14:37:06 PDT
(In reply to Antti Koivisto from comment #3) > Comment on attachment 346293 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=346293&action=review > > > Source/WebCore/layout/FloatingState.h:64 > > + FloatingList m_floatings; > > Is "floatings" a spec term or something? To me "floats" sounds better. spec calls floats in many ways: "The most interesting characteristic of a float (or "floated" or "floating" box).." I actually prefer "floats" too. AFAIR the only reason why I picked floating was not to confuse it with the primitive type, but I guess it's really hard to confuse them in this context. I'll rename them in a separate patch.
zalan
Comment 5 2018-08-01 14:46:57 PDT
Committed r234481: <https://trac.webkit.org/changeset/234481>
Radar WebKit Bug Importer
Comment 6 2018-08-01 20:32:46 PDT
<rdar://problem/42840449>
Note You need to log in before you can comment on or make changes to this bug.