Bug 188231 - JSArrayBuffer should have its own JSType
Summary: JSArrayBuffer should have its own JSType
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Keith Miller
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2018-08-01 12:09 PDT by Keith Miller
Modified: 2018-08-01 20:26 PDT (History)
5 users (show)

See Also:

Attachments
Patch (2.72 KB, patch)
2018-08-01 12:10 PDT, Keith Miller 		saam: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Keith Miller 2018-08-01 12:09:41 PDT 
JSArrayBuffer should have its own JSType
Comment 1 Keith Miller 2018-08-01 12:10:09 PDT 
Created attachment 346286 [details]
Patch
Comment 2 Keith Miller 2018-08-01 13:34:02 PDT 
Committed r234468: <https://trac.webkit.org/changeset/234468>
Comment 3 Darin Adler 2018-08-01 18:50:48 PDT 
You forgot to say why.
Comment 4 Keith Miller 2018-08-01 18:51:56 PDT 
(In reply to Darin Adler from comment #3)
> You forgot to say why.

I'm going to use this in a future, larger patch, so I figured I'd break it out.
Comment 5 Saam Barati 2018-08-01 19:07:06 PDT 
(In reply to Keith Miller from comment #4)
> (In reply to Darin Adler from comment #3)
> > You forgot to say why.
> 
> I'm going to use this in a future, larger patch, so I figured I'd break it
> out.

For posterity when people look up this bug, it gives us a single load+compare in jsDynamicCast.
Comment 6 Radar WebKit Bug Importer 2018-08-01 20:26:31 PDT 
<rdar://problem/42840295>