Bug 188227 - Use iPhone SE as the default simulated device
Summary: Use iPhone SE as the default simulated device
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Jonathan Bedard
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2018-08-01 10:35 PDT by Jonathan Bedard
Modified: 2018-08-01 20:26 PDT (History)
8 users (show)

See Also:


Attachments
Patch (1.09 KB, patch)
2018-08-01 11:53 PDT, Jonathan Bedard
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Jonathan Bedard 2018-08-01 10:35:05 PDT
This is long overdue.

We need to be using a newer device when running layout tests on simulated devices. This should probably be either the iPhone 8 or iPhone X, but those have a different screen size than the iPhone 5s, so we will need to change some test expectations. In the mean time, let's use the iPhone SE
Comment 1 Jonathan Bedard 2018-08-01 11:53:45 PDT
Created attachment 346284 [details]
Patch
Comment 2 WebKit Commit Bot 2018-08-01 13:29:35 PDT
Comment on attachment 346284 [details]
Patch

Clearing flags on attachment: 346284

Committed r234467: <https://trac.webkit.org/changeset/234467>
Comment 3 WebKit Commit Bot 2018-08-01 13:29:37 PDT
All reviewed patches have been landed.  Closing bug.
Comment 4 Radar WebKit Bug Importer 2018-08-01 20:26:25 PDT
<rdar://problem/42840280>