Bug 188215 - Convert calc-related enums to 8-bit enum classes
Summary: Convert calc-related enums to 8-bit enum classes
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Simon Fraser (smfr)
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2018-07-31 22:33 PDT by Simon Fraser (smfr)
Modified: 2018-08-02 12:21 PDT (History)
5 users (show)

See Also:


Attachments
Patch (51.54 KB, patch)
2018-07-31 22:34 PDT, Simon Fraser (smfr)
no flags Details | Formatted Diff | Diff
Archive of layout-test-results from ews205 for win-future (12.91 MB, application/zip)
2018-08-01 14:35 PDT, EWS Watchlist
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Simon Fraser (smfr) 2018-07-31 22:33:41 PDT
Convert calc-related enums to 8-bit enum classes
Comment 1 Simon Fraser (smfr) 2018-07-31 22:34:43 PDT
Created attachment 346261 [details]
Patch
Comment 2 EWS Watchlist 2018-07-31 22:37:34 PDT
Attachment 346261 [details] did not pass style-queue:


ERROR: Source/WebCore/platform/CalculationValue.h:186:  Please replace ASSERT_WITH_SECURITY_IMPLICATION() with RELEASE_ASSERT_WITH_SECURITY_IMPLICATION().  [security/assertion] [5]
ERROR: Source/WebCore/platform/CalculationValue.h:203:  Please replace ASSERT_WITH_SECURITY_IMPLICATION() with RELEASE_ASSERT_WITH_SECURITY_IMPLICATION().  [security/assertion] [5]
ERROR: Source/WebCore/platform/CalculationValue.h:218:  Please replace ASSERT_WITH_SECURITY_IMPLICATION() with RELEASE_ASSERT_WITH_SECURITY_IMPLICATION().  [security/assertion] [5]
ERROR: Source/WebCore/platform/CalculationValue.h:229:  Please replace ASSERT_WITH_SECURITY_IMPLICATION() with RELEASE_ASSERT_WITH_SECURITY_IMPLICATION().  [security/assertion] [5]
Total errors found: 4 in 9 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 EWS Watchlist 2018-08-01 14:35:30 PDT
Comment on attachment 346261 [details]
Patch

Attachment 346261 [details] did not pass win-ews (win):
Output: https://webkit-queues.webkit.org/results/8726306

New failing tests:
http/tests/security/canvas-remote-read-remote-video-localhost.html
Comment 4 EWS Watchlist 2018-08-01 14:35:41 PDT
Created attachment 346300 [details]
Archive of layout-test-results from ews205 for win-future

The attached test failures were seen while running run-webkit-tests on the win-ews.
Bot: ews205  Port: win-future  Platform: CYGWIN_NT-6.1-2.9.0-0.318-5-3-x86_64-64bit
Comment 5 WebKit Commit Bot 2018-08-02 12:19:40 PDT
Comment on attachment 346261 [details]
Patch

Clearing flags on attachment: 346261

Committed r234506: <https://trac.webkit.org/changeset/234506>
Comment 6 WebKit Commit Bot 2018-08-02 12:19:41 PDT
All reviewed patches have been landed.  Closing bug.
Comment 7 Radar WebKit Bug Importer 2018-08-02 12:21:10 PDT
<rdar://problem/42867817>