Bug 188210 - [GStreamer] Make sure that first buffer running time is 0 in GStreamerMediaStreamSource
Summary: [GStreamer] Make sure that first buffer running time is 0 in GStreamerMediaSt...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Thibault Saunier
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2018-07-31 16:36 PDT by Thibault Saunier
Modified: 2018-08-01 20:25 PDT (History)
4 users (show)

See Also:

Attachments
Patch (3.56 KB, patch)
2018-07-31 16:47 PDT, Thibault Saunier 		no flags Details | Formatted Diff | Diff
Patch (3.56 KB, patch)
2018-08-01 05:41 PDT, Thibault Saunier 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Thibault Saunier 2018-07-31 16:36:25 PDT 
[GStreamer] Make sure that first buffer running time is 0 in GStreamerMediaStreamSource
Comment 1 Thibault Saunier 2018-07-31 16:47:13 PDT 
Created attachment 346222 [details]
Patch
Comment 2 Alejandro G. Castro 2018-07-31 23:51:29 PDT 
Comment on attachment 346222 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=346222&action=review

LGTM, just fix the typo.

> Source/WebCore/platform/mediastream/gstreamer/GStreamerMediaStreamSource.cpp:512
> +            auto pad = adoptGRef(gst_element_get_static_pad(self->videoSrc, "src"));

Probably this is a small typo and you wanted to use audioSrc.
Comment 3 Thibault Saunier 2018-08-01 05:41:11 PDT 
Created attachment 346273 [details]
Patch

Fix typo
Comment 4 WebKit Commit Bot 2018-08-01 06:35:45 PDT 
Comment on attachment 346273 [details]
Patch

Clearing flags on attachment: 346273

Committed r234457: <https://trac.webkit.org/changeset/234457>
Comment 5 WebKit Commit Bot 2018-08-01 06:35:46 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 6 Radar WebKit Bug Importer 2018-08-01 20:25:14 PDT 
<rdar://problem/42840249>