Bug 188207 – [iOS] Color picker should have a border when presented in a popover

• Status: RESOLVED
• Resolution: FIXED
• Component: Forms

[Aditya Keerthi]

The color picker should have a border when presented in a popover (on iPad).

[Aditya Keerthi]

Created attachment 346213 [details]
Patch

[Wenson Hsieh]

Comment on attachment 346213 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=346213&action=review

> Source/WebKit/UIProcess/ios/forms/WKFormColorControl.mm:58
> +    RetainPtr<UIView> controlContainerView = [[UIView alloc] initWithFrame:CGRectMake(0, 0, colorPopoverWidth, colorPopoverWidth)];

adoptNS!

[Aditya Keerthi]

Created attachment 346214 [details]
Patch

[Aditya Keerthi]

Will rebase this patch on trunk once 188124 is in.

[Wenson Hsieh]

Comment on attachment 346214 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=346214&action=review

> Source/WebKit/ChangeLog:11
> +        Since the popover will resize it's view to fill it's size, we first place the

Super nit — it's => its

> Source/WebKit/ChangeLog:13
> +        while the smaller color picker is centered in it's container - creating the

Here too.

[Aditya Keerthi]

Created attachment 346279 [details]
Patch

[WebKit Commit Bot]

Comment on attachment 346279 [details]
Patch

Clearing flags on attachment: 346279

Committed r234461: <https://trac.webkit.org/changeset/234461>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Radar WebKit Bug Importer]

<rdar://problem/42840315>