The color picker should have a border when presented in a popover (on iPad).
Created attachment 346213 [details]
Comment on attachment 346213 [details]
View in context: https://bugs.webkit.org/attachment.cgi?id=346213&action=review
> + RetainPtr<UIView> controlContainerView = [[UIView alloc] initWithFrame:CGRectMake(0, 0, colorPopoverWidth, colorPopoverWidth)];
Created attachment 346214 [details]
Will rebase this patch on trunk once 188124 is in.
Comment on attachment 346214 [details]
View in context: https://bugs.webkit.org/attachment.cgi?id=346214&action=review
> + Since the popover will resize it's view to fill it's size, we first place the
Super nit — it's => its
> + while the smaller color picker is centered in it's container - creating the
Created attachment 346279 [details]
Comment on attachment 346279 [details]
Clearing flags on attachment: 346279
Committed r234461: <https://trac.webkit.org/changeset/234461>
All reviewed patches have been landed. Closing bug.