Bug 188207 - [iOS] Color picker should have a border when presented in a popover
Summary: [iOS] Color picker should have a border when presented in a popover
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Forms (show other bugs)
Version: WebKit Nightly Build
Hardware: iPhone / iPad Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords: InRadar
Depends on: 188124
Blocks:
  Show dependency treegraph
 
Reported: 2018-07-31 15:59 PDT by Aditya Keerthi
Modified: 2018-08-01 20:26 PDT (History)
4 users (show)

See Also:


Attachments
Patch (3.65 KB, patch)
2018-07-31 16:06 PDT, Aditya Keerthi
no flags Details | Formatted Diff | Diff
Patch (3.66 KB, patch)
2018-07-31 16:13 PDT, Aditya Keerthi
no flags Details | Formatted Diff | Diff
Patch (3.57 KB, patch)
2018-08-01 09:07 PDT, Aditya Keerthi
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Aditya Keerthi 2018-07-31 15:59:29 PDT
The color picker should have a border when presented in a popover (on iPad).
Comment 1 Aditya Keerthi 2018-07-31 16:06:18 PDT
Created attachment 346213 [details]
Patch
Comment 2 Wenson Hsieh 2018-07-31 16:09:26 PDT
Comment on attachment 346213 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=346213&action=review

> Source/WebKit/UIProcess/ios/forms/WKFormColorControl.mm:58
> +    RetainPtr<UIView> controlContainerView = [[UIView alloc] initWithFrame:CGRectMake(0, 0, colorPopoverWidth, colorPopoverWidth)];

adoptNS!
Comment 3 Aditya Keerthi 2018-07-31 16:13:24 PDT
Created attachment 346214 [details]
Patch
Comment 4 Aditya Keerthi 2018-07-31 16:13:52 PDT
Will rebase this patch on trunk once 188124 is in.
Comment 5 Wenson Hsieh 2018-07-31 16:37:34 PDT
Comment on attachment 346214 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=346214&action=review

> Source/WebKit/ChangeLog:11
> +        Since the popover will resize it's view to fill it's size, we first place the

Super nit — it's => its

> Source/WebKit/ChangeLog:13
> +        while the smaller color picker is centered in it's container - creating the

Here too.
Comment 6 Aditya Keerthi 2018-08-01 09:07:53 PDT
Created attachment 346279 [details]
Patch
Comment 7 WebKit Commit Bot 2018-08-01 10:26:24 PDT
Comment on attachment 346279 [details]
Patch

Clearing flags on attachment: 346279

Committed r234461: <https://trac.webkit.org/changeset/234461>
Comment 8 WebKit Commit Bot 2018-08-01 10:26:25 PDT
All reviewed patches have been landed.  Closing bug.
Comment 9 Radar WebKit Bug Importer 2018-08-01 20:26:43 PDT
<rdar://problem/42840315>