Bug 188204 - Add TransformationMatrix::Identity
Summary: Add TransformationMatrix::Identity
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Yusuke Suzuki
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2018-07-31 12:42 PDT by Yusuke Suzuki
Modified: 2018-08-01 21:10 PDT (History)
3 users (show)

See Also:

Attachments
Patch (3.43 KB, patch)
2018-07-31 12:43 PDT, Yusuke Suzuki 		no flags Details | Formatted Diff | Diff
Patch (3.48 KB, patch)
2018-08-01 01:23 PDT, Yusuke Suzuki 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Yusuke Suzuki 2018-07-31 12:42:51 PDT 
Add TransformationMatrix::Identity
Comment 1 Yusuke Suzuki 2018-07-31 12:43:38 PDT 
Created attachment 346191 [details]
Patch
Comment 2 Yusuke Suzuki 2018-08-01 01:23:18 PDT 
Created attachment 346265 [details]
Patch
Comment 3 Yusuke Suzuki 2018-08-01 08:33:55 PDT 
Comment on attachment 346265 [details]
Patch

Thanks
Comment 4 WebKit Commit Bot 2018-08-01 09:01:07 PDT 
Comment on attachment 346265 [details]
Patch

Clearing flags on attachment: 346265

Committed r234460: <https://trac.webkit.org/changeset/234460>
Comment 5 WebKit Commit Bot 2018-08-01 09:01:09 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 6 Darin Adler 2018-08-01 09:55:26 PDT 
Comment on attachment 346265 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=346265&action=review

> Source/WebCore/platform/graphics/transforms/TransformationMatrix.h:121
> +    static const TransformationMatrix Identity;

Seems fine to define this, but unclear to me why its name is capitalized given WebKit coding style.
Comment 7 Radar WebKit Bug Importer 2018-08-01 20:34:52 PDT 
<rdar://problem/42840494>
Comment 8 Yusuke Suzuki 2018-08-01 20:40:14 PDT 
Comment on attachment 346265 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=346265&action=review

>> Source/WebCore/platform/graphics/transforms/TransformationMatrix.h:121
>> +    static const TransformationMatrix Identity;
> 
> Seems fine to define this, but unclear to me why its name is capitalized given WebKit coding style.

Ah, I named it as `Identity` since we have `JSCell::StructureFlags` static const variable, but it seems this is rather exceptional. Changed in a follow-up patch.
Comment 9 Yusuke Suzuki 2018-08-01 21:10:48 PDT 
Committed r234492: <https://trac.webkit.org/changeset/234492>